Skip to content

Chore/update mission deps#13938

Merged
komret merged 3 commits intodevelopfrom
chore/update-mission-deps
Aug 27, 2024
Merged

Chore/update mission deps#13938
komret merged 3 commits intodevelopfrom
chore/update-mission-deps

Conversation

@komret
Copy link
Copy Markdown
Contributor

@komret komret commented Aug 22, 2024

Update all Mission-related dependencies except Electron (updated recently by #13795) and tiny-secp256k1 (WIP in #12261). Also, not realy sure what to do with bcrypto.

@komret komret added the dependencies Pull requests that update a dependency file label Aug 22, 2024
@komret komret force-pushed the chore/update-mission-deps branch 5 times, most recently from b92748b to 44999ac Compare August 23, 2024 12:20
@komret komret requested a review from Lemonexe August 23, 2024 13:04
@komret
Copy link
Copy Markdown
Contributor Author

komret commented Aug 23, 2024

I don't know why this breaks a mobile XRP test...

@vytick
Copy link
Copy Markdown
Contributor

vytick commented Aug 23, 2024

Looks like upgrade of jssha might have broken something related to XRP.
Screenshot 2024-08-23 at 16 33 38

@komret komret force-pushed the chore/update-mission-deps branch 2 times, most recently from 3065b64 to 2a2f2d8 Compare August 26, 2024 16:32
@komret
Copy link
Copy Markdown
Contributor Author

komret commented Aug 26, 2024

No idea how to fix that :( I reverted it back to the previous version. This dependency will be handled by @trezor/suite-connect team.

@komret komret force-pushed the chore/update-mission-deps branch from 2a2f2d8 to 6a4a9bf Compare August 26, 2024 17:08
@komret
Copy link
Copy Markdown
Contributor Author

komret commented Aug 27, 2024

/rebase

@github-actions
Copy link
Copy Markdown

@trezor-ci trezor-ci force-pushed the chore/update-mission-deps branch from 6a4a9bf to 92f5195 Compare August 27, 2024 08:26
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI is fine ✔️

Comment thread packages/utxo-lib/src/bip32.ts
@komret komret merged commit a304dd5 into develop Aug 27, 2024
@komret komret deleted the chore/update-mission-deps branch August 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants