Skip to content

chore: add support for vllm v0.19.0#898

Merged
tjohnson31415 merged 13 commits intotorch-spyre:mainfrom
rafvasq:support-v0.19.0
Apr 8, 2026
Merged

chore: add support for vllm v0.19.0#898
tjohnson31415 merged 13 commits intotorch-spyre:mainfrom
rafvasq:support-v0.19.0

Conversation

@rafvasq
Copy link
Copy Markdown
Collaborator

@rafvasq rafvasq commented Apr 6, 2026 •
edited by tjohnson31415
Loading

Description

Add support for vLLM v0.19.0

  • bump vllm versions
  • Inputs reorganization (#35182)
  • get_cross_encoder_act_fn merged into get_act_fn (#37537)
  • RequestStatus.WAITING_FOR_FSM renamed to WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR (#38048)
  • prompt_token_ids_cpu arg in PoolingMetadata (#38139)

Related Issues

Checklist

  • I have read the contributing guidelines
  • My code follows the project's code style (run bash format.sh)
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My commits include a Signed-off-by: line (DCO compliance)

rafvasq added 2 commits April 6, 2026 15:13
@rafvasq
chore: add support for vllm v0.19.0
d8b1e5d 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Merge branch 'main' into support-v0.19.0
0c95186 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

rafvasq added 6 commits April 6, 2026 15:22
@rafvasq
fix uv lock
f88cb76 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Formats
1225c52 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
More fixes
5aa37f6 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Add prompt_token_ids_cpu arg
7275fcd 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Ruff
2b4833f 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Formats
06b1e8f 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Copy link
Copy Markdown
Collaborator Author

rafvasq commented Apr 6, 2026

bot:test

@rafvasq
Copy link
Copy Markdown
Collaborator Author

rafvasq commented Apr 7, 2026

bot:test
MARKERS="spyre and prefix_caching and not quantized"

@rafvasq rafvasq marked this pull request as ready for review April 7, 2026 14:11
maxdebayser
maxdebayser reviewed Apr 7, 2026
View reviewed changes
Comment thread tests/utils/test_upstream_compatibility.py Outdated
tjohnson31415
tjohnson31415 reviewed Apr 7, 2026
View reviewed changes
Comment thread pyproject.toml Outdated
maxdebayser
maxdebayser approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@maxdebayser maxdebayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rafvasq added 4 commits April 7, 2026 15:53
@rafvasq
Remove v0.18.x backwards compat
3c65b3f 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Restore empty upstream compat test file
c8366c4 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
consolidate prompt_token_ids_cpu code
5608191 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
lints
2b0a319 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Copy link
Copy Markdown
Collaborator Author

rafvasq commented Apr 7, 2026

bot:test
MARKERS="spyre and prefix_caching and not quantized"

tjohnson31415
tjohnson31415 reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the backwards compat code.
Just some NITs and one comment we should not remove (but the comment should be updated).

Comment thread tests/v1/core/test_scheduler_structured_outputs.py Outdated
Comment thread tests/utils/test_platform_validation.py Outdated
Comment thread vllm_spyre/v1/worker/spyre_model_runner.py Outdated
Comment thread vllm_spyre/platform.py Outdated
Comment thread vllm_spyre/platform.py
@rafvasq
Address nits
a3963bb 
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@rafvasq
Copy link
Copy Markdown
Collaborator Author

rafvasq commented Apr 8, 2026

bot:test
MARKERS="spyre and prefix_caching and not quantized"

tjohnson31415
tjohnson31415 approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjohnson31415 tjohnson31415 merged commit 3e8e966 into torch-spyre:main Apr 8, 2026
15 checks passed
@rafvasq rafvasq deleted the support-v0.19.0 branch April 8, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxdebayser maxdebayser maxdebayser approved these changes

@tjohnson31415 tjohnson31415 tjohnson31415 approved these changes

@prashantgupta24 prashantgupta24 Awaiting requested review from prashantgupta24 prashantgupta24 is a code owner

@sducouedic sducouedic Awaiting requested review from sducouedic sducouedic is a code owner

@yannicks1 yannicks1 Awaiting requested review from yannicks1 yannicks1 is a code owner

@tdoublep tdoublep Awaiting requested review from tdoublep tdoublep is a code owner

@nikolaospapandreou nikolaospapandreou Awaiting requested review from nikolaospapandreou nikolaospapandreou is a code owner

@joerunde joerunde Awaiting requested review from joerunde joerunde is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rafvasq @maxdebayser @tjohnson31415