[Refactor] Rename WAITING_FOR_FSM to WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR#38048
Merged
yewentao256 merged 2 commits intomainfrom Mar 25, 2026
Merged
[Refactor] Rename WAITING_FOR_FSM to WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR#38048yewentao256 merged 2 commits intomainfrom
WAITING_FOR_FSM to WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR#38048yewentao256 merged 2 commits intomainfrom
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
requested review from
ApostaC,
WoosukKwon,
aarnphm,
alexm-redhat,
benchislett,
heheda12345,
mgoin,
njhill,
orozery,
robertgshaw2-redhat,
russellb and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the RequestStatus.WAITING_FOR_FSM enum value to RequestStatus.WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR across various files, including its definition, usage in the scheduler logic, request initialization, and corresponding tests. The review suggests further renaming of test names, variables, and comments in test_scheduler.py to ensure full consistency with the new terminology and improve code clarity.
Member
Author
|
Hi @orozery , what's your thought? |
Collaborator
|
LMK if you want to wait for @orozery, or just merge. |
Member
Author
|
Merge this PR as it doesn't have functional change and @orozery isn't against with it. |
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Mar 27, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
malaiwah
pushed a commit
to malaiwah/vllm
that referenced
this pull request
Mar 27, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
Etelis
pushed a commit
to Etelis/vllm
that referenced
this pull request
Mar 29, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
bhargav-patel-29
pushed a commit
to Bharatgen-Tech/vllm
that referenced
this pull request
Apr 1, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: bhargav-patel-29 <bhargav.patel@tihiitb.org>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
5 tasks
rishitdholakia13
pushed a commit
to rishitdholakia13/vllm
that referenced
this pull request
Apr 7, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: rishitdholakia13 <rishit+github@cohere.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
tjohnson31415
pushed a commit
to vllm-project/vllm-spyre
that referenced
this pull request
Apr 8, 2026
<!-- markdownlint-disable --> ## Description Add support for vLLM v0.19.0 - bump vllm versions - Inputs reorganization ([#35182](vllm-project/vllm#35182)) - `get_cross_encoder_act_fn` merged into `get_act_fn` ([#37537](vllm-project/vllm#37537)) - `RequestStatus.WAITING_FOR_FSM` renamed to `WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR` ([#38048](vllm-project/vllm#38048)) - `prompt_token_ids_cpu` arg in PoolingMetadata ([#38139](vllm-project/vllm#38139)) ## Related Issues <!-- Link related issues, e.g., `Fixes #` or `Relates to #456` --> ## Checklist - [x] I have read the [contributing guidelines](https://docs.vllm.ai/projects/spyre/en/latest/contributing) - [x] My code follows the project's code style (run `bash format.sh`) - [x] I have added tests for my changes (if applicable) - [ ] I have updated the documentation (if applicable) - [x] My commits include a `Signed-off-by:` line (DCO compliance) --------- Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
5 tasks
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…_GRAMMAR` (vllm-project#38048) Signed-off-by: yewentao256 <zhyanwentao@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
WAITING_FOR_FSM is a confusing name, rename to WAITING_FOR_STRUCTURED_OUTPUT_GRAMMAR for easier understand.