[Misc] Reorganize inputs#35182
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Documentation preview: https://vllm--35182.org.readthedocs.build/en/35182/ |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Hi @DarkLight1337, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
cc @njhill - the fundamental change to this PR is that we want to avoid using I'd like to make sure we decide on an interface for token-in-token-out and stick to it to avoid any additional refactoring/renaming in the future, so let's be careful with it. |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the input organization within vLLM by splitting vllm.inputs.data into vllm.inputs.api and vllm.inputs.engine, and standardizing the naming conventions (e.g., ProcessorInputs to EngineInput). The changes improve code clarity and help prevent circular dependencies by moving multi-modal input definitions. The refactoring is comprehensive, covering numerous files across the engine, entrypoints, and model implementations. I have identified a few minor issues related to docstring references and potential type safety in helper functions that should be addressed to maintain high code quality.
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
njhill
left a comment
There was a problem hiding this comment.
Looks ok to me since it doesn't really change things from current state w.r.t. my above concerns, so we can continue to discuss those things anyhow.
sorry about the delay
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: johnnynunez <johnnynuca14@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: johnnynunez <johnnynuca14@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Purpose
ProcessorInputs -> EngineInputto avoid confusion about where it should be inputted.TokenInputs -> TokensInputtoken_inputs-> tokens_inputEmbedsInputs -> EmbedsInputSingletonInputs -> SingletonInputvllm.inputs.data.vllm.inputs.llm.vllm.inputs.engine.vllm.inputs.parse.split_enc_dec_inputs -> vllm.inputs.engine.split_enc_dec_input.vllm.multimodal.inputs.ModalityData -> vllm.inputs.llm.ModalityDatavllm.multimodal.inputs.MultiModalDataBuiltins -> vllm.inputs.llm.MultiModalDataBuiltinsvllm.multimodal.inputs.MultiModalDataDict -> vllm.inputs.llm.MultiModalDataDictvllm.multimodal.inputs.MultiModalUUIDDict -> vllm.inputs.llm.MultiModalUUIDDictvllm.multimodal.inputs.MultiModalHashes -> vllm.inputs.engine.MultiModalHashesvllm.multimodal.inputs.MultiModalPlaceholderDict -> vllm.inputs.engine.MultiModalPlaceholdersvllm.multimodal.inputs.MultiModalInputs -> vllm.inputs.engine.MultiModalInputvllm.multimodal.inputs.mm_inputs -> vllm.inputs.engine.mm_inputvllm.multimodal.inputs.MultiModalEncDecInputs -> vllm.inputs.engine.MultiModalEncDecInputvllm.multimodal.inputs.mm_enc_dec_inputs -> vllm.inputs.engine.mm_enc_dec_inputTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.