Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): search page ui #8012

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

CatsJuice
Copy link
Member

feat(mobile): search page ui

fix(core): quick search tags performance issue

Copy link

graphite-app bot commented Aug 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Aug 29, 2024

Copy link

nx-cloud bot commented Aug 29, 2024

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (5e8683c) to head (f1bb1fc).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...rontend/core/src/modules/quicksearch/impls/tags.ts 4.76% 20 Missing ⚠️
...tend/core/src/modules/quicksearch/services/cmdk.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8012      +/-   ##
==========================================
- Coverage   52.79%   52.77%   -0.03%     
==========================================
  Files        1207     1209       +2     
  Lines       47811    47835      +24     
  Branches     5811     5814       +3     
==========================================
+ Hits        25242    25244       +2     
- Misses      22189    22211      +22     
  Partials      380      380              
Flag Coverage Δ
server-test 77.65% <ø> (ø)
unittest 25.72% <8.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice changed the base branch from catsjuice/feat/mobile-pages to graphite-base/8012 August 29, 2024 06:11
@CatsJuice CatsJuice changed the base branch from graphite-base/8012 to canary August 29, 2024 06:25
Copy link

graphite-app bot commented Aug 29, 2024

Merge activity

feat(mobile): search page ui

fix(core): quick search tags performance issue
@EYHN EYHN force-pushed the catsjuice/feat/mobile-search branch from ca89958 to f1bb1fc Compare August 29, 2024 09:05
@graphite-app graphite-app bot merged commit f1bb1fc into canary Aug 29, 2024
33 of 34 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/mobile-search branch August 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants