Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): adjust peek view style for mobile #8003

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 28, 2024

image.png

Copy link
Collaborator Author

pengx17 commented Aug 28, 2024

@pengx17 pengx17 marked this pull request as ready for review August 28, 2024 14:37
@graphite-app graphite-app bot requested review from JimmFly, EYHN, forehalo and CatsJuice and removed request for forehalo August 28, 2024 14:37
Copy link

nx-cloud bot commented Aug 28, 2024

@pengx17 pengx17 force-pushed the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch from 11fd245 to e457c37 Compare August 28, 2024 14:38
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.73%. Comparing base (7ae141b) to head (adf314d).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #8003   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files        1209     1209           
  Lines       47840    47840           
  Branches     5814     5814           
=======================================
  Hits        25228    25228           
  Misses      22232    22232           
  Partials      380      380           
Flag Coverage Δ
server-test 77.58% <ø> (ø)
unittest 25.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch 2 times, most recently from 7ae43b4 to 5e2ae50 Compare August 29, 2024 06:24
@CatsJuice CatsJuice force-pushed the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch from e457c37 to 99b6ee9 Compare August 29, 2024 06:24
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from 5e2ae50 to 6af1392 Compare August 29, 2024 09:52
@pengx17 pengx17 force-pushed the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch from 99b6ee9 to 036f693 Compare August 29, 2024 09:52
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from 6af1392 to f800fdd Compare August 29, 2024 10:02
@pengx17 pengx17 force-pushed the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch from 036f693 to 1b2bd87 Compare August 29, 2024 10:02
@pengx17 pengx17 mentioned this pull request Aug 29, 2024
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from f800fdd to db93cc3 Compare August 29, 2024 13:48
@pengx17 pengx17 force-pushed the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch 2 times, most recently from 0762bdd to d8e3ad7 Compare August 29, 2024 14:09
Copy link

graphite-app bot commented Aug 29, 2024

Merge activity

@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from db93cc3 to 7ae141b Compare August 29, 2024 16:46
@pengx17 pengx17 force-pushed the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch from d8e3ad7 to adf314d Compare August 29, 2024 16:46
Base automatically changed from 08-27-feat_mobile_add_mobile_detail_page to canary August 29, 2024 16:57
@graphite-app graphite-app bot merged commit adf314d into canary Aug 29, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-28-fix_mobile_adjust_peek_view_style_for_mobile branch August 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants