Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): mobile index page UI #7959

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

CatsJuice
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

CatsJuice commented Aug 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added docs Improvements or additions to documentation app:core labels Aug 23, 2024
@CatsJuice CatsJuice marked this pull request as ready for review August 23, 2024 08:19
Copy link

nx-cloud bot commented Aug 23, 2024

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 52.76%. Comparing base (f37051d) to head (db76780).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...core/src/modules/workbench/view/workbench-link.tsx 5.88% 16 Missing ⚠️
packages/frontend/core/src/pages/index.tsx 20.00% 4 Missing ⚠️
.../src/components/page-list/page-content-preview.tsx 33.33% 2 Missing ⚠️
packages/frontend/core/src/shared/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7959      +/-   ##
==========================================
- Coverage   52.76%   52.76%   -0.01%     
==========================================
  Files        1207     1207              
  Lines       47801    47804       +3     
  Branches     5806     5808       +2     
==========================================
  Hits        25223    25223              
- Misses      22199    22202       +3     
  Partials      379      379              
Flag Coverage Δ
server-test 77.58% <ø> (ø)
unittest 25.75% <11.53%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-index branch 2 times, most recently from b9e947c to 29bb129 Compare August 26, 2024 02:46
Copy link

graphite-app bot commented Aug 29, 2024

Merge activity

@CatsJuice CatsJuice force-pushed the catsjuice/feat/mobile-explorer branch from 85ec7a1 to f37051d Compare August 29, 2024 06:09
Base automatically changed from catsjuice/feat/mobile-explorer to canary August 29, 2024 06:22
@graphite-app graphite-app bot merged commit db76780 into canary Aug 29, 2024
32 of 33 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/mobile-index branch August 29, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core docs Improvements or additions to documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants