Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): add mobile detail page #7993

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 27, 2024

fix AF-1241

Copy link
Collaborator Author

pengx17 commented Aug 27, 2024

Copy link

nx-cloud bot commented Aug 27, 2024

Copy link

graphite-app bot commented Aug 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (f8e6f1f) to head (7ae141b).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...nents/blocksuite/block-suite-editor/lit-adaper.tsx 0.00% 1 Missing ⚠️
packages/frontend/core/src/utils/event.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7993      +/-   ##
==========================================
- Coverage   52.76%   52.73%   -0.03%     
==========================================
  Files        1209     1209              
  Lines       47835    47840       +5     
  Branches     5813     5814       +1     
==========================================
- Hits        25238    25228      -10     
- Misses      22214    22232      +18     
+ Partials      383      380       -3     
Flag Coverage Δ
server-test 77.58% <ø> (ø)
unittest 25.73% <89.47%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch 2 times, most recently from 5a111f7 to 341a4f5 Compare August 27, 2024 15:20
@pengx17 pengx17 force-pushed the catsjuice/feat/mobile-pages branch from 7ccf870 to 007aecd Compare August 28, 2024 10:19
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch 3 times, most recently from 76609c7 to 7d6be3e Compare August 28, 2024 14:18
@pengx17 pengx17 marked this pull request as ready for review August 28, 2024 14:19
@CatsJuice CatsJuice changed the base branch from catsjuice/feat/mobile-pages to graphite-base/7993 August 29, 2024 06:11
@CatsJuice CatsJuice force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from 7d6be3e to 7ae43b4 Compare August 29, 2024 06:23
@CatsJuice CatsJuice changed the base branch from graphite-base/7993 to canary August 29, 2024 06:24
@CatsJuice CatsJuice force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from 7ae43b4 to 5e2ae50 Compare August 29, 2024 06:24
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from 5e2ae50 to 6af1392 Compare August 29, 2024 09:52
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from 6af1392 to f800fdd Compare August 29, 2024 10:02
@pengx17 pengx17 changed the base branch from canary to 08-29-chore_add_mobile_scope August 29, 2024 10:02
@pengx17 pengx17 mentioned this pull request Aug 29, 2024
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from f800fdd to db93cc3 Compare August 29, 2024 13:48
Copy link

graphite-app bot commented Aug 29, 2024

Merge activity

@pengx17 pengx17 force-pushed the 08-29-chore_add_mobile_scope branch from 4f8c54a to f8e6f1f Compare August 29, 2024 16:45
@pengx17 pengx17 force-pushed the 08-27-feat_mobile_add_mobile_detail_page branch from db93cc3 to 7ae141b Compare August 29, 2024 16:46
Base automatically changed from 08-29-chore_add_mobile_scope to canary August 29, 2024 16:56
@graphite-app graphite-app bot merged commit 7ae141b into canary Aug 29, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-27-feat_mobile_add_mobile_detail_page branch August 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants