api: support query regions by read/write flow. #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a PR description. |
Connor1996
reviewed
Jan 2, 2018
| // Pop removes the minimum element (according to Less) from the heap and returns | ||
| // it. | ||
| func (h *RegionHeap) Pop() interface{} { | ||
| pos := len(h.regions) - 1 |
There was a problem hiding this comment.
I think it would be better check whether Len() is zero
There was a problem hiding this comment.
It is the caller's responsibility to avoid poping an empty heap. You can refer the heap example: https://golang.org/src/container/heap/example_intheap_test.go
siddontang
reviewed
Jan 2, 2018
server/api/region.go
Outdated
|
|
||
| const defaultRegionLimit = 16 | ||
|
|
||
| func (h *regionsHandler) GetTopWriteFlow(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
can we combine TopRead/WriteFlow? They use nearly same codes.
There was a problem hiding this comment.
Addressed. PTAL @siddontang
siddontang
reviewed
Jan 2, 2018
| } | ||
|
|
||
| // RegionHeap implements heap.Interface, used for selecting top n regions. | ||
| type RegionHeap struct { |
There was a problem hiding this comment.
any independent test for RegionHeap?
There was a problem hiding this comment.
I guess not necessary. It is only a straightforward adapter to wrap a slice into heap.Interface.
There was a problem hiding this comment.
If we add some tests for it, we are actually testing the algorithms in golang library.
There was a problem hiding this comment.
but here it not only for golang lib, we have min and TopN too.
siddontang
reviewed
Jan 2, 2018
server/api/region.go
Outdated
| return h.regions[0] | ||
| } | ||
|
|
||
| func (h *regionsHandler) TopNRegions(regions []*core.RegionInfo, less func(a, b *core.RegionInfo) bool, n int) []*core.RegionInfo { |
There was a problem hiding this comment.
can we use TopN directly here?
siddontang
reviewed
Jan 9, 2018
server/api/region.go
Outdated
| return nil | ||
| } | ||
|
|
||
| hp := &RegionHeap{less: less} |
There was a problem hiding this comment.
need preallocation here?
|
Rest LGTM |
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tools/pd-tso-bench (#5990) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref prometheus/client_golang#987, ref #987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/client (#5992) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/mcs (#5993) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /client (#5991) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query for the top N regions by readFlow/writeFlow.
Usage:
HTTP:
pd-ctl: