server: fix frequent alloc id #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
Apr 8, 2018
server/schedule/replica_checker.go
Outdated
| @@ -83,7 +83,7 @@ func (r *ReplicaChecker) Check(region *core.RegionInfo) *Operator { | |||
|
|
|||
| // SelectBestReplacedPeerToAddReplica returns a new peer that to be used to replace the old peer and distinct score. | |||
| func (r *ReplicaChecker) SelectBestReplacedPeerToAddReplica(region *core.RegionInfo, oldPeer *metapb.Peer, filters ...Filter) *metapb.Peer { | |||
| storeID, _ := r.selectBestReplacementStore(region, oldPeer, filters...) | |||
| storeID, _ := r.SelectBestReplacementStore(region, oldPeer, filters...) | |||
There was a problem hiding this comment.
I think we can remove the function SelectBestReplacedPeerToAddReplica to prevent we misuse it later.
disksing
reviewed
Apr 8, 2018
server/schedule/replica_checker.go
Outdated
| } | ||
| newPeer, err := r.cluster.AllocPeer(storeID) | ||
| if err != nil { | ||
| log.Info("alloc peer meet error:", err) |
There was a problem hiding this comment.
I think we can use log.Error.
server/schedule/replica_checker.go
Outdated
| @@ -228,6 +219,7 @@ func (r *ReplicaChecker) checkBestReplacement(region *core.RegionInfo) *Operator | |||
| } | |||
| newPeer, err := r.cluster.AllocPeer(storeID) | |||
| if err != nil { | |||
| log.Info("alloc peer meet error:", err) | |||
|
PTAL @disksing |
disksing
reviewed
Apr 9, 2018
| @@ -154,6 +154,10 @@ func (s *balanceRegionScheduler) transferPeer(cluster schedule.Cluster, region * | |||
| schedulerCounter.WithLabelValues(s.GetName(), "skip").Inc() | |||
| return nil | |||
| } | |||
| newPeer, err := cluster.AllocPeer(storeID) | |||
| if err != nil { | |||
| schedulerCounter.WithLabelValues(s.GetName(), "no_peer").Inc() | |||
server/schedule/replica_checker.go
Outdated
| } | ||
| newPeer, err := r.cluster.AllocPeer(storeID) | ||
| if err != nil { | ||
| log.Error("alloc peer meet error:", err) |
There was a problem hiding this comment.
I have a second thought here. It seems better to move the log into AllocPeer function.
There was a problem hiding this comment.
yeah, I check that found has already printed.
|
/run-all-tests |
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tools/pd-tso-bench (#5990) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref prometheus/client_golang#987, ref #987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/client (#5992) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /tests/mcs (#5993) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot
added a commit
that referenced
this pull request
Feb 15, 2023
…1.11.1 in /client (#5991) ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the balance region may alloc peer but do not produce operator.