Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offline store need be considered in balance leader/region #974

Closed
disksing opened this issue Mar 5, 2018 · 3 comments · Fixed by #983
Closed

offline store need be considered in balance leader/region #974

disksing opened this issue Mar 5, 2018 · 3 comments · Fixed by #983
Assignees
@nolouch
Labels
component/schedule Scheduling logic. type/enhancement The issue or PR belongs to an enhancement.

Comments

@disksing
Copy link
Contributor

disksing commented Mar 5, 2018

When a store is not up, it is excluded from the leader/region balance. I think a better behavior  would be:

  1. If the count(or size) of an offline store is below average, we can exclude it in balancers.
  2. If the count(or size) of an offline store is above average, we should consider it in balancers.
@disksing disksing added type/enhancement The issue or PR belongs to an enhancement. component/schedule Scheduling logic. labels Mar 5, 2018
@huachaohuang
Copy link
Contributor

I think we can limit an offline store as a source store (but not a target store) in balancers.

@nolouch nolouch self-assigned this Mar 6, 2018
@nolouch
Copy link
Contributor

nolouch commented Mar 8, 2018

Maybe we can consider a new single fail-over balance, now checker couldn't found abnormal region immediately. and there are some priorities for scheduling the fail store regions. like hot region.

@disksing
Copy link
Contributor Author

disksing commented Mar 8, 2018

Yes we can. But I guess it's not related to this issue.

@nolouch nolouch mentioned this issue Mar 8, 2018
Merged
ti-chi-bot pushed a commit that referenced this issue Feb 15, 2023
@dependabot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
3a286c2 
…1.11.1 in /tools/pd-tso-bench (#5990)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref prometheus/client_golang#987, ref #987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot pushed a commit that referenced this issue Feb 15, 2023
@dependabot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
e168bd6 
…1.11.1 in /tests/client (#5992)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ti-chi-bot added a commit that referenced this issue Feb 15, 2023
@dependabot @ti-chi-bot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
2839786 
…1.11.1 in /tests/mcs (#5993)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ti Chi Robot <[email protected]>
ti-chi-bot added a commit that referenced this issue Feb 15, 2023
@dependabot @ti-chi-bot
build(deps): bump github.com/prometheus/client_golang from 1.11.0 to …
951dbc6 
…1.11.1 in /client (#5991)

ref #897, ref #962, ref #969, ref #974, ref #975, ref #976, ref #986, ref #987, ref prometheus/client_golang#987, ref #989, ref #998, ref #1013, ref #1014, ref #1025, ref #1028, ref #1031, ref #1043, ref #1055, ref #1075, ref #1091, ref #1094, ref #1102, ref #1103, ref #1118, ref #1146, ref #1148, ref #1150, ref #4399

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nolouch nolouch

Labels
component/schedule Scheduling logic. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schdule: exclude offline store in filter source nolouch/pd
3 participants
@nolouch @huachaohuang @disksing