Skip to content

github-ci: melodic and noetic initial commit#194

Merged
Levi-Armstrong merged 5 commits into
tesseract-robotics:masterfrom
brisa-robotics:master
Oct 5, 2020
Merged

github-ci: melodic and noetic initial commit#194
Levi-Armstrong merged 5 commits into
tesseract-robotics:masterfrom
brisa-robotics:master

Conversation

@Minipada
Copy link
Copy Markdown
Contributor

@Minipada Minipada commented Jul 7, 2020

Hi,
Happy to participate in the World ROS I day activity with Brisa Robotics.

Here are my proposed changes to build on Melodic and Noetic.
I know melodic was not requested but it was a good starting point for me to get into Github actions.
In the ci file, you will notice melodic uses upstream but Noetic uses a tesseract fork I created (see https://github.com/brisa-robotics/tesseract/tree/noetic)

Some infos:
The reason for that is the switch to python3 in Noetic which makes packages.xml non compatible anymore.
python becomes python3
python-numpy becomes python3-numpy
orocos_kdl becomes liborocos-kdl-dev

For python3-numpy, see:
ros/rosdistro#24035

Regarding orocos, see mentions here:
ros/rosdistro#24009
ros/geometry2#447
and example there
https://github.com/ros/geometry2/pull/447/files

Finally,
I ignored ifopt in Noetic at the moment, it has no release since lunar (source: https://github.com/ethz-adrl/ifopt-release). You probably want to release one or we need to add an entry in rosdistro at least if lunar version is used

Correct me if I'm wrong, but now there are 2 possibilities on how to proceed.

  1. Do you create a noetic branch on tesseract where I'd do a PR, and then change the github action file to point there?
  2. Or do you make all python2 deprecated and i do a PR on master where python3 is mandatory
    Last point: should i remove the travis file?

Since this is part of World ROS I day, I'm available on google meet and irc if you want to discuss into more details.

Build result: https://github.com/brisa-robotics/trajopt_ros/runs/846092749?check_suite_focus=true

@gavanderhoorn gavanderhoorn added the wrid20 World ROS-Industrial Day 2020 label Jul 7, 2020
Copy link
Copy Markdown
Contributor

@mpowelson mpowelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I should have been more clear in my issue, we actually wanted a bionic build so that is fine. I was just listing the new builds we wanted to add in addition to the ones in Travis. While you don't have to add them if you don't want to, eventually we will want to add xenial, clang-tidy, clang-format, and codecov builds that we have in Tesseract

Comment thread .github/workflows/main.yml Outdated
Comment thread .github/workflows/main.yml Outdated
@Minipada
Copy link
Copy Markdown
Contributor Author

Minipada commented Jul 8, 2020

To complete the ticket, Foxy was also requested. I could make it work but I had to apply changes to the Dockerfile. Should I make a PR on the dockerfile repo first?

@mpowelson
Copy link
Copy Markdown
Contributor

To complete the ticket, Foxy was also requested. I could make it work but I had to apply changes to the Dockerfile. Should I make a PR on the dockerfile repo first?

Yeah if you don't mind, that would be great.

@Minipada
Copy link
Copy Markdown
Contributor Author

I just noticed I commented on another PR.
Please ping me when foxy is on https://hub.docker.com/r/lharmstrong/tesseract/tags, i'll add the github action CI build right after.

@Levi-Armstrong Levi-Armstrong merged commit fac43eb into tesseract-robotics:master Oct 5, 2020
@gavanderhoorn gavanderhoorn removed the wrid20 World ROS-Industrial Day 2020 label Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants