Add tesseract build for foxy#35
Merged
Merged
Conversation
also changed the build arguments since there is no foxy-perception tag yet
|
I'll tag @Levi-Armstrong as well since he was the author of these images. |
Levi-Armstrong
suggested changes
Jul 9, 2020
| FROM ros:$ROS_BASE_TAG | ||
| MAINTAINER Levi Armstrong | ||
|
|
||
| ARG ROSDISTRO |
Member
There was a problem hiding this comment.
Missing ARG ROS_BASE_TAG here.
Contributor
Author
There was a problem hiding this comment.
It's already at line 2
Member
|
@Minipada Also the dockers are not building in CI. |
Member
|
It looks like you cannot pass two args to --build-arg. So need to change the line below removing the --build-arg and change CI to have Line 25 in 8bee190 |
Levi-Armstrong
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding a build for Foxy for tesseract.
foxy-perceptiontag yet. This follows the work started on github-ci: melodic and noetic initial commit tesseract-robotics/trajopt#194@mpowelson, you probably want to review this.