Skip to content

Build: Consolidate and update nx versions#32449

Merged
ndelangen merged 2 commits into
storybookjs:nextfrom
mrginglymus:update-nx
Sep 16, 2025
Merged

Build: Consolidate and update nx versions#32449
ndelangen merged 2 commits into
storybookjs:nextfrom
mrginglymus:update-nx

Conversation

@mrginglymus
Copy link
Copy Markdown
Contributor

@mrginglymus mrginglymus commented Sep 14, 2025

What I did

Way back when nx was updated. However, this PR missed @nx/vite et al, effectively duplicating the number of nx dependencies.

I noticed this while poking through the lockfile looking for easy trims, and figured I'd throw a PR together to see what explodes.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This represents only a patch release in the main version of nx, so I expect testing here to be a case of everything will work fine as it did before, or catastrophic failure. If things were somehow working with mismatched versions but fail with matched versions, something has gone terribly wrong.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updated On: 2025-09-14 19:59:59 UTC

This PR consolidates and updates nx dependency versions across the Storybook monorepo by aligning all nx-related packages to version 20.8.2. The changes update @nx/vite and @nx/workspace from version 20.2.2 to 20.8.2, and nx from ^20.4.0 to 20.8.2 in the root package.json.

The motivation for this change stems from a previous PR (#30460) that updated the main nx package but missed updating related nx packages like @nx/vite, creating version mismatches that resulted in duplicate dependencies in the lockfile. This type of version fragmentation is common in monorepos when dependencies are updated incrementally rather than as a cohesive group.

The change follows best practices for monorepo tooling where related packages from the same ecosystem should be kept in sync. Nx is Storybook's build and development tooling infrastructure, used for managing the complex monorepo structure, running tasks, and coordinating builds across multiple packages. By consolidating these versions, the PR reduces the dependency footprint and eliminates potential compatibility issues between different versions of the same toolchain.

This represents a patch-level upgrade (20.2.2 → 20.8.2) that includes bug fixes and improvements without breaking changes, making it a safe consolidation that should maintain full backward compatibility.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only consolidates versions of related tooling dependencies
  • Score reflects the patch-level nature of the upgrade and the fact that mismatched versions were already working, so aligned versions should work even better
  • No files require special attention as this is a straightforward dependency version alignment

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Sep 14, 2025

View your CI Pipeline Execution ↗ for commit e3c092d

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-15 14:35:57 UTC

@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Sep 15, 2025
@ndelangen ndelangen merged commit db5f3cd into storybookjs:next Sep 16, 2025
52 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
24 tasks
@mrginglymus mrginglymus deleted the update-nx branch September 16, 2025 08:13
@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants