Build: Consolidate and update nx versions#32449
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit e3c092d
☁️ Nx Cloud last updated this comment at |
ndelangen
approved these changes
Sep 15, 2025
24 tasks
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Way back when
nxwas updated. However, this PR missed@nx/viteet al, effectively duplicating the number ofnxdependencies.I noticed this while poking through the lockfile looking for easy trims, and figured I'd throw a PR together to see what explodes.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This represents only a patch release in the main version of
nx, so I expect testing here to be a case of everything will work fine as it did before, or catastrophic failure. If things were somehow working with mismatched versions but fail with matched versions, something has gone terribly wrong.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updated On: 2025-09-14 19:59:59 UTC
This PR consolidates and updates nx dependency versions across the Storybook monorepo by aligning all nx-related packages to version 20.8.2. The changes update
@nx/viteand@nx/workspacefrom version 20.2.2 to 20.8.2, andnxfrom ^20.4.0 to 20.8.2 in the rootpackage.json.The motivation for this change stems from a previous PR (#30460) that updated the main
nxpackage but missed updating related nx packages like@nx/vite, creating version mismatches that resulted in duplicate dependencies in the lockfile. This type of version fragmentation is common in monorepos when dependencies are updated incrementally rather than as a cohesive group.The change follows best practices for monorepo tooling where related packages from the same ecosystem should be kept in sync. Nx is Storybook's build and development tooling infrastructure, used for managing the complex monorepo structure, running tasks, and coordinating builds across multiple packages. By consolidating these versions, the PR reduces the dependency footprint and eliminates potential compatibility issues between different versions of the same toolchain.
This represents a patch-level upgrade (20.2.2 → 20.8.2) that includes bug fixes and improvements without breaking changes, making it a safe consolidation that should maintain full backward compatibility.
Confidence score: 5/5