Release: Prerelease 8.6.0-alpha.4#30439
Merged
Merged
Conversation
…torybook into norbert/typescript-upgrade
…torybook into norbert/typescript-upgrade
Build: Upgrade `typescript`
Docs: Update Next.js Tailwind example link
Docs: Add Preact-vite framework docs
RNW-Vite: Fix typos
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
102 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| "find-package-json": "^1.2.0", | ||
| "magic-string": "^0.30.0", | ||
| "typescript": "^5.0.0", | ||
| "typescript": "^5.7.3", |
Contributor
There was a problem hiding this comment.
style: typescript dependency is duplicated in both dependencies and devDependencies - consider removing from one location
Suggested change
| "typescript": "^5.7.3", |
|
|
||
| #### `builder` | ||
|
|
||
| Type: `Record<string, any>` |
Contributor
There was a problem hiding this comment.
style: Consider adding more specific type information beyond Record<string, any>
| ); | ||
| } | ||
| const data = await response.json(); | ||
| const data: any = await response.json(); |
Contributor
There was a problem hiding this comment.
style: Consider defining a TypeScript interface for the npm registry response data structure instead of using any
| }); | ||
|
|
||
| const result = await res.json(); | ||
| const result: any = await res.json(); |
Contributor
There was a problem hiding this comment.
style: Consider defining a proper interface for the GitHub API response instead of using any to maintain type safety
…ptional Addon A11y: Make Vitest Axe optional
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-alpha.3
branch
from
d6fe118 to
012baa6
Compare
Build: Add flag to skip nx cache
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-alpha.3
branch
from
012baa6 to
e4715c4
Compare
Build: Update NX
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-alpha.3
branch
from
e4715c4 to
37ec630
Compare
…-generation Build: Set TypeScript resolution for sandbox generation
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-alpha.3
branch
from
37ec630 to
8f6ad6c
Compare
…lcted-addon UI: Fix default selected addon panel
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-alpha.3
branch
from
8f6ad6c to
dbfdfda
Compare
Builder-Vite: Fix allowedHosts handling for custom hosts
storybook-bot
force-pushed
the
version-non-patch-from-8.6.0-alpha.3
branch
from
dbfdfda to
2c62084
Compare
shilman
added
freeze
|
View your CI Pipeline Execution ↗ for commit 2c62084.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 56 | 🎉 -3 🎉 |
| Self size | 228 KB | 332 KB | 🚨 +104 KB 🚨 |
| Dependency size | 13.46 MB | 12.71 MB | 🎉 -753 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-docs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 17 | 17 | 0 |
| Self size | 2.20 MB | 2.26 MB | 🚨 +61 KB 🚨 |
| Dependency size | 7.92 MB | 7.92 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-essentials
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 36 | 36 | 0 |
| Self size | 12 KB | 12 KB | 0 B |
| Dependency size | 13.87 MB | 13.93 MB | 🚨 +61 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 13 | 13 | 0 |
| Self size | 6 KB | 5 KB | 🎉 -743 B 🎉 |
| Dependency size | 1.31 MB | 1.31 MB | 🚨 +2 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 388 | 388 | 0 |
| Self size | 503 KB | 503 KB | 🎉 -310 B 🎉 |
| Dependency size | 75.36 MB | 75.37 MB | 🚨 +12 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.6.0-alpha.3to8.6.0-alpha.4.Once this pull request is merged, it will trigger a new release of version
8.6.0-alpha.4.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:typescript#30354If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.6.0-alpha.4