fix(ade): skip sb installation if no explicit skill invocation by huang-julien · Pull Request #302 · storybookjs/mcp

huang-julien · 2026-06-19T14:38:13Z

This pull request updates the prerequisites for Storybook-related skills to clarify the behavior when Storybook is not installed. Now, the skills will silently ignore the absence of Storybook unless the user explicitly invokes the skill, instead of stopping and requiring user opt-in.

Storybook Skill Prerequisite Updates:

Updated the prerequisite instructions in SKILL.md files to specify that if Storybook is not installed and the skill is not explicitly invoked by the user, the skill should be silently ignored. [1] [2]

Summary by CodeRabbit

Bug Fixes
- Improved handling when Storybook isn’t installed: story-related tasks are now skipped automatically unless the skill was explicitly invoked. When invoked, the user is prompted to set up Storybook and proceed; declining will skip story work while still allowing any non-story component changes to complete.

changeset-bot · 2026-06-19T14:38:17Z

⚠️ No Changeset found

Latest commit: 600e63f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2026-06-19T14:38:18Z

✅ Deploy Preview for storybook-mcp-self-host-example canceled.

Name	Link
🔨 Latest commit	`600e63f`
🔍 Latest deploy log	https://app.netlify.com/projects/storybook-mcp-self-host-example/deploys/6a355f888066ca0008313f1a

pkg-pr-new · 2026-06-19T14:38:44Z

npx https://pkg.pr.new/storybookjs/mcp/@storybook/addon-mcp@302

npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp@302

npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp-proxy@302

commit: 600e63f

Copilot

Pull request overview

Updates the Storybook “stories” skill documentation in both the Codex and Claude plugins to avoid running (or prompting) when Storybook isn’t installed unless the user explicitly invoked the skill.

Changes:

Adjusted the “Storybook must be installed” prerequisite in the Codex Storybook stories skill doc.
Adjusted the same prerequisite in the Claude stories skill doc to match.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md	Updates prerequisite wording to conditionally skip the skill when Storybook isn’t installed and the skill wasn’t explicitly invoked.
packages/claude-plugin/skills/stories/SKILL.md	Mirrors the same prerequisite behavior change for the Claude plugin skill doc.

 ## Prerequisites

- Storybook must be installed in the project. If it is not, go to "When Storybook is not installed" below and stop here unless the user opts in.
+- Storybook must be installed in the project. If it is not installed and if this skill is not explicitly invoked by the user, silently ignore this skill.



- Storybook must be installed in the project. If it is not, go to
-  "When Storybook is not installed" below and stop here unless the user opts in.
+- Storybook must be installed in the project. If it is not installed and if this skill is not explicitly invoked by the user, silently ignore this skill.


codecov · 2026-06-19T14:40:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.78%. Comparing base (f19d42e) to head (600e63f).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   79.68%   79.78%   +0.09%     
==========================================
  Files          67       67              
  Lines        2048     2048              
  Branches      578      578              
==========================================
+ Hits         1632     1634       +2     
+ Misses        235      234       -1     
+ Partials      181      180       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

coderabbitai · 2026-06-19T14:41:44Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ff758973-e3bb-4be5-a599-91cfcd97af58

📥 Commits

Reviewing files that changed from the base of the PR and between 28e340d and 600e63f.

📒 Files selected for processing (2)

packages/claude-plugin/skills/stories/SKILL.md
packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md

📝 Walkthrough

Walkthrough

Two SKILL.md files (claude-plugin and codex-plugin) update the "Storybook must be installed" prerequisite rule. The prior behavior branched into a "When Storybook is not installed" flow; the new behavior silently ignores all story work when Storybook is absent and the skill was not explicitly invoked by the user.

Changes

Silent skip when Storybook not installed

Layer / File(s)	Summary
Prerequisite update across both plugin SKILL.md files `packages/claude-plugin/skills/stories/SKILL.md`, `packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md`	The "Storybook must be installed" prerequisite in each file is updated to silently skip story work when Storybook is not installed and the skill was not explicitly invoked, replacing the prior instruction to branch into the "When Storybook is not installed" user-facing flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

storybookjs/mcp#297: This PR implements the skill rewrite proposed in #297, applying the same prerequisite restructuring for missing Storybook (ask user when explicitly invoked) to both the Claude and Codex SKILL.md files.

Possibly related PRs

storybookjs/mcp#300: Overlaps in the same Storybook SKILL.md prerequisite/gating workflow instructions by reworking the "Storybook not installed" and prerequisites sections.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+- Storybook must be installed in the project. If it is not installed:
+  - If this skill is not explicitly invoked by the user, silently ignore this skill.
+  - Otherwise, ask the user whether they want to set up Storybook and write stories.
+    - If the user decline, silently skip all story work, finish the component change (if any), and move on.


+ - Storybook must be installed in the project. If it is not installed:
+   - If this skill is not explicitly invoked by the user, silently ignore this skill.
+   - Otherwise, ask the user whether they want to set up Storybook and write stories.
+    - If the user decline, silently skip all story work, finish the component change (if any), and move on.
+    - If the user accepts, invoke the **storybook-setup** skill to set up Storybook and write stories.


Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

+- Storybook must be installed in the project. If it is not installed:
+  - If this skill is not explicitly invoked by the user, silently ignore this skill.
+  - Otherwise, ask the user whether they want to set up Storybook and write stories.
+    - If the user decline, silently skip all story work, finish the component change (if any), and move on.


+- Storybook must be installed in the project. If it is not installed:
+  - If this skill is not explicitly invoked by the user, silently ignore this skill.
+  - Otherwise, ask the user whether they want to set up Storybook and write stories.
+  - If the user decline, silently skip all story work, finish the component change (if any), and move on.


kasperpeulen · 2026-06-19T15:24:20Z

+  - If this skill is not explicitly invoked by the user, silently ignore this skill.
+  - Otherwise, ask the user whether they want to set up Storybook and write stories.
+  - If the user decline, silently skip all story work, finish the component change (if any), and move on.
+  - If the user accepts, invoke the **storybook-setup** skill to set up Storybook and write stories.


The storybook-init skill right?

oops indeed

fix(ade): skip stories skill if no explicit skill invocation

bfca2af

Copilot AI review requested due to automatic review settings June 19, 2026 14:38

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Copilot started reviewing on behalf of huang-julien June 19, 2026 14:40

View session

huang-julien added 2 commits June 19, 2026 16:45

wording

28e340d

remove optout file

1058f2f

Copilot AI review requested due to automatic review settings June 19, 2026 15:03

Copilot started reviewing on behalf of huang-julien June 19, 2026 15:03

View session

chore: format

1dde8f8

huang-julien changed the title ~~fix(ade): skip stories skill if no explicit skill invocation~~ fix(ade): skip sb installation if no explicit skill invocation Jun 19, 2026

Copilot AI reviewed Jun 19, 2026

View reviewed changes

huang-julien requested a review from Copilot June 19, 2026 15:18

Copilot started reviewing on behalf of huang-julien June 19, 2026 15:19

View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

kasperpeulen approved these changes Jun 19, 2026

View reviewed changes

fix: call init skill

600e63f

huang-julien merged commit 3db949d into main Jun 19, 2026
15 checks passed

huang-julien deleted the feat/fix_skill_ignore_installation_on_implicit_invokation branch June 19, 2026 15:27

coderabbitai Bot mentioned this pull request Jul 7, 2026

fix: duplicate prerequisite instructions into skills #343

Closed

Conversation

huang-julien commented Jun 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

netlify Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for storybook-mcp-self-host-example canceled.

Uh oh!

pkg-pr-new Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codecov Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kasperpeulen Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

huang-julien Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

huang-julien commented Jun 19, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Jun 19, 2026 •

edited

Loading

netlify Bot commented Jun 19, 2026 •

edited

Loading

pkg-pr-new Bot commented Jun 19, 2026 •

edited

Loading

codecov Bot commented Jun 19, 2026 •

edited

Loading

coderabbitai Bot commented Jun 19, 2026 •

edited

Loading