This repository was archived by the owner on Oct 14, 2026. It is now read-only.
Repository navigation
fix: duplicate prerequisite instructions into skills - #343
Closed
huang-julien wants to merge 1 commit into
Closed
huang-julien wants to merge 1 commit into
huang-julien wants to merge 1 commit into
Conversation
|
✅ Deploy Preview for storybook-mcp-self-host-example canceled.
|
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 79.71% 79.66% -0.05%
==========================================
Files 50 50
Lines 2085 2095 +10
Branches 619 624 +5
==========================================
+ Hits 1662 1669 +7
Misses 220 220
- Partials 203 206 +3 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Storybook “skill” markdown files so each skill carries its own prerequisite guidance (instead of relying on a shared prerequisite file that the model can’t access outside the skill directory).
Changes:
- Added a shared “Prerequisites” block to the
init,upgrade, andstoriesskills in both the codex-plugin and claude-plugin variants. - Reworded the
storiesprerequisites to a clearer conditional form (“not installed / outdated / up to date”). - Simplified
setupprerequisites to a single-line summary.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/codex-plugin/plugins/storybook/skills/upgrade/SKILL.md | Adds prerequisites block to the codex “upgrade” skill. |
| packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md | Replaces older prerequisite wording with the standardized conditional block. |
| packages/codex-plugin/plugins/storybook/skills/setup/SKILL.md | Changes prerequisites to a one-line summary. |
| packages/codex-plugin/plugins/storybook/skills/init/SKILL.md | Adds prerequisites block to the codex “init” skill. |
| packages/claude-plugin/skills/storybook-upgrade/SKILL.md | Adds prerequisites block to the claude “storybook-upgrade” skill. |
| packages/claude-plugin/skills/storybook-setup/SKILL.md | Changes prerequisites to a one-line summary. |
| packages/claude-plugin/skills/storybook-init/SKILL.md | Adds prerequisites block to the claude “storybook-init” skill. |
| packages/claude-plugin/skills/stories/SKILL.md | Replaces older prerequisite wording with the standardized conditional block. |
Comment on lines
+6
to
+10
| Prerequisites: | ||
|
|
||
| 1. **Storybook is not installed** (no Storybook dependencies in `package.json`, no `.storybook/` directory): invoke the `$storybook:init` skill, but only if the user explicitly approves a Storybook installation. | ||
| 2. **Storybook is installed but outdated** (version < 10.5 and not an alpha/canary version): invoke the `$storybook:upgrade` skill, but only if the user explicitly approved a Storybook upgrade. | ||
| 3. **Storybook is installed and up to date**: proceed. Ensure `@storybook/addon-mcp` is installed; if it is missing, install it with `npx storybook add @storybook/addon-mcp`. |
Comment on lines
+6
to
+10
| Prerequisites: | ||
|
|
||
| 1. **Storybook is not installed** (no Storybook dependencies in `package.json`, no `.storybook/` directory): invoke the `$storybook:init` skill, but only if the user explicitly approves a Storybook installation. | ||
| 2. **Storybook is installed but outdated** (version < 10.5 and not an alpha/canary version): invoke the `$storybook:upgrade` skill, but only if the user explicitly approved a Storybook upgrade. | ||
| 3. **Storybook is installed and up to date**: proceed. Ensure `@storybook/addon-mcp` is installed; if it is missing, install it with `npx storybook add @storybook/addon-mcp`. |
|
|
||
| 1. Confirm Storybook exists (`package.json`, `.storybook/`). If not, switch to `$storybook:init`. | ||
| 2. If Storybook is outdated or upgrade/repair is needed first, switch to `$storybook:upgrade`. | ||
| Prerequisites: Storybook must already be installed and up to date. If it is not installed, switch to `$storybook:init`; if it is outdated, switch to `$storybook:upgrade`. |
Comment on lines
+6
to
+10
| Prerequisites: | ||
|
|
||
| 1. **Storybook is not installed** (no Storybook dependencies in `package.json`, no `.storybook/` directory): invoke the `/storybook-init` skill, but only if the user explicitly approves a Storybook installation. | ||
| 2. **Storybook is installed but outdated** (version < 10.5 and not an alpha/canary version): invoke the `/storybook-upgrade` skill, but only if the user explicitly approved a Storybook upgrade. | ||
| 3. **Storybook is installed and up to date**: proceed. Ensure `@storybook/addon-mcp` is installed; if it is missing, install it with `npx storybook add @storybook/addon-mcp`. |
Comment on lines
+6
to
+10
| Prerequisites: | ||
|
|
||
| 1. **Storybook is not installed** (no Storybook dependencies in `package.json`, no `.storybook/` directory): invoke the `/storybook-init` skill, but only if the user explicitly approves a Storybook installation. | ||
| 2. **Storybook is installed but outdated** (version < 10.5 and not an alpha/canary version): invoke the `/storybook-upgrade` skill, but only if the user explicitly approved a Storybook upgrade. | ||
| 3. **Storybook is installed and up to date**: proceed. Ensure `@storybook/addon-mcp` is installed; if it is missing, install it with `npx storybook add @storybook/addon-mcp`. |
|
|
||
| 1. Confirm Storybook exists (`package.json`, `.storybook/`). If not, switch to `/storybook-init`. | ||
| 2. If Storybook is outdated or upgrade/repair is needed first, switch to `/storybook-upgrade`. | ||
| Prerequisites: Storybook must already be installed and up to date. If it is not installed, switch to `/storybook-init`; if it is outdated, switch to `/storybook-upgrade`. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughDocumentation updates across eight SKILL.md files in claude-plugin and codex-plugin Storybook skills, replacing prior simple installation/version prerequisites with a three-branch decision flow: not installed (approval-gated init), outdated below 10.5 excluding alpha/canary (approval-gated upgrade), or up to date (proceed and ensure addon-mcp is installed). ChangesStorybook skill Prerequisites documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suplicate prerequisite instructions into all skills.
Another solution would be to have a duplciated
<skill>/references/PREQUISITE.mdbut it 's basically the same thing.Having a single
storybook/skills/PREQUISITIE.mddoesn't work because claude don't have permission to read any files outside of a skill directory.Summary by CodeRabbit