Repository navigation
feat(ade): rework the skills for serverless ai command - #300
Conversation
|
✅ Deploy Preview for storybook-mcp-self-host-example canceled.
|
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 79.68% 79.78% +0.09%
==========================================
Files 67 67
Lines 2048 2048
Branches 578 578
==========================================
+ Hits 1632 1634 +2
+ Misses 235 234 -1
+ Partials 181 180 -1 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
This PR updates the “stories” skills used by the Codex and Claude plugins to shift the workflow emphasis toward loading Storybook AI CLI guidance first, and to de-emphasize starting/opening the preview browser unless needed by specific subcommands.
Changes:
- Removes the strict “gated workflow” preamble and renames “Step 0 — Prerequisites” to “Prerequisites”.
- Reorders the workflow so “Load the rules (before touching any story file)” comes before preview setup guidance.
- Moves the preview-browser instructions under a subsection and makes them conditional (“only if you need a subcommand that requires Storybook running”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md | Reorders the stories workflow to load CLI rules first and downgrades preview-browser prominence. |
| packages/claude-plugin/skills/stories/SKILL.md | Mirrors the same workflow rework for the Claude plugin variant. |
| ## Load the rules (before touching any story file) | ||
|
|
||
| - Run `STORYBOOK_FEATURE_AI_CLI=1 npx storybook ai --help` with `require_escalated` to get all available subcommands and options. This also gets the latest rules for how to write stories. | ||
| - Save the available subcommands and options in your working memory for reference. | ||
| - Some subcommands are only available when Storybook is running. If you need to run a subcommand that requires Storybook, follow the instructions in "Guarantee a running preview browser" below to start Storybook and open the preview browser. |
| ## Load the rules (before touching any story file) | ||
|
|
||
| - Run `STORYBOOK_FEATURE_AI_CLI=1 npx storybook ai --help` to get all available subcommands and options. This also gets the latest rules for how to write stories. | ||
| - Save the available subcommands and options in your working memory for reference. | ||
| - Some subcommands are only available when Storybook is running. If you need to run a subcommand that requires Storybook, follow the instructions in "Opening the preview browser up front" below to start Storybook and open the preview browser. |
📝 WalkthroughWalkthroughBoth ChangesStorybook SKILL.md Workflow Restructure
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related issues
Possibly related PRs
Warning Tools execution failed with the following error: Failed to run tools: Ping-pong health check failed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md (1)
61-64:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate stale "Step 1" reference in recovery flow (mirrors claude-plugin issue).
After restructuring, the workflow no longer has a "Step 1" heading. Lines 62–63 reference "resume this workflow from Step 1", which is now a broken internal reference. This mirrors the same issue in the claude-plugin file and must be fixed consistently across both files.
Update the reference to point to the correct section: "resume this workflow from the 'Load the rules' section."
Suggested fix
4. **If the user opts in**, set Storybook up via the setup skills - (`init` / `setup`), then resume this workflow from - Step 1. If you recorded a decline at either scope from a previous "no", clear + (`init` / `setup`), then resume this workflow from the + "Load the rules" section. If you recorded a decline at either scope from a previous "no", clear it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md` around lines 61 - 64, The text in the recovery flow instructions contains a stale reference to "Step 1" which no longer exists after workflow restructuring. Update the phrase "resume this workflow from Step 1" in the conditional block starting with "If the user opts in" to instead read "resume this workflow from the 'Load the rules' section" to point to the correct section heading that now exists in the reorganized workflow.packages/claude-plugin/skills/stories/SKILL.md (1)
73-76:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate stale "Step 1" reference in recovery flow.
After restructuring, the workflow no longer has a "Step 1" heading. Line 75 references "resume this workflow from Step 1", which is now a broken internal reference. An agent following this instruction to recover from a Storybook setup decline will be confused about where to resume.
Update the reference to point to the correct section: "resume this workflow from the 'Load the rules' section" or "resume this workflow from the 'Absolute rules' and 'Load the rules' sections."
Suggested fix
4. **If the user opts in**, set Storybook up via the setup skills - (`storybook-init` / `storybook-setup`), then resume this workflow from - Step 1. If you recorded a decline at either scope from a previous "no", clear + (`storybook-init` / `storybook-setup`), then resume this workflow from the + "Load the rules" section. If you recorded a decline at either scope from a previous "no", clear it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/claude-plugin/skills/stories/SKILL.md` around lines 73 - 76, The reference to "Step 1" in the recovery flow instruction (in the "If the user opts in" section where users opt in to Storybook setup) is a broken internal reference since the workflow was restructured and no longer contains a "Step 1" heading. Replace the phrase "resume this workflow from Step 1" with the correct section reference "resume this workflow from the 'Load the rules' section" or "resume this workflow from the 'Absolute rules' and 'Load the rules' sections" to ensure agents following the recovery flow can correctly locate where to resume after completing the Storybook setup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/claude-plugin/skills/stories/SKILL.md`:
- Around line 73-76: The reference to "Step 1" in the recovery flow instruction
(in the "If the user opts in" section where users opt in to Storybook setup) is
a broken internal reference since the workflow was restructured and no longer
contains a "Step 1" heading. Replace the phrase "resume this workflow from Step
1" with the correct section reference "resume this workflow from the 'Load the
rules' section" or "resume this workflow from the 'Absolute rules' and 'Load the
rules' sections" to ensure agents following the recovery flow can correctly
locate where to resume after completing the Storybook setup.
In `@packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md`:
- Around line 61-64: The text in the recovery flow instructions contains a stale
reference to "Step 1" which no longer exists after workflow restructuring.
Update the phrase "resume this workflow from Step 1" in the conditional block
starting with "If the user opts in" to instead read "resume this workflow from
the 'Load the rules' section" to point to the correct section heading that now
exists in the reorganized workflow.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3b9ba4b0-58ad-4698-88b7-f5c087654259
📒 Files selected for processing (2)
packages/claude-plugin/skills/stories/SKILL.mdpackages/codex-plugin/plugins/storybook/skills/stories/SKILL.md
This rework stories skill for serverless ai commands.
It also loosen a bit on the instructions to agents for less context bloating. The preview browser also becomes something less important, as part of the instructions helper
Summary by CodeRabbit