Skip to content
This repository was archived by the owner on Oct 14, 2026. It is now read-only.

feat(ade): remove port mention in skills - #303

Merged
huang-julien merged 2 commits into
mainfrom
feat/remove_port
Jun 22, 2026
Merged

huang-julien merged 2 commits into
mainfrom
feat/remove_port

Conversation

@huang-julien

@huang-julien huang-julien commented Jun 19, 2026 •

Copy link
Copy Markdown
Contributor

storybookjs/storybook#35235 (comment)

Summary by CodeRabbit

Release Notes

  • Documentation
    • Simplified Storybook preview browser initialization procedures for improved clarity
    • Streamlined server readiness verification and preview URL detection workflows
    • Updated instructions for opening and maintaining preview browser instances across different scenarios

Copilot AI review requested due to automatic review settings June 19, 2026 15:04
@changeset-bot

changeset-bot Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 94b502c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for storybook-mcp-self-host-example canceled.

Name Link
🔨 Latest commit 94b502c
🔍 Latest deploy log https://app.netlify.com/projects/storybook-mcp-self-host-example/deploys/6a356004132c680008b0ad24

@coderabbitai

coderabbitai Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5f54cbc-72a9-4d92-be51-424753319a08

📥 Commits

Reviewing files that changed from the base of the PR and between 3db949d and 94b502c.

📒 Files selected for processing (2)
  • packages/claude-plugin/skills/stories/SKILL.md
  • packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md

📝 Walkthrough

Walkthrough

Two SKILL.md files—one in the Claude plugin and one in the Codex plugin—have their Storybook preview startup instructions simplified. Steps that tracked a specific port via autoPort and required recording that port for subsequent subcommands are replaced with instructions to wait for server readiness and open the preview browser directly.

Changes

Storybook Preview Startup Instruction Simplification

Layer / File(s) Summary
Remove autoPort guidance from preview startup steps
packages/claude-plugin/skills/stories/SKILL.md, packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md
Step 3 in the Claude plugin and the "no running instance" flow in the Codex plugin both drop the prior autoPort-specific steps (wait for port, record it, reuse it for subcommands) and replace them with instructions to wait for server readiness and open the Storybook preview in the preview browser.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

  • storybookjs/mcp#290: Modifies the same Storybook preview-browser workflow steps in the Codex plugin SKILL.md, overlapping with this PR's changes to the same section.
  • storybookjs/mcp#300: Restructures the same "open/guarantee running preview browser" gating workflow sections that this PR edits.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 19, 2026 •

Copy link
Copy Markdown
npx https://pkg.pr.new/storybookjs/mcp/@storybook/addon-mcp@303
npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp@303
npx https://pkg.pr.new/storybookjs/mcp/@storybook/mcp-proxy@303

commit: 94b502c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes instructions in Storybook “skills” docs that tell the agent to remember and reuse Storybook’s port, aligning the guidance with workflows that rely on the preview URL rather than a stored port.

Changes:

  • Removed “save the port in working memory” guidance when detecting an existing Storybook instance.
  • Updated “start Storybook” instructions to avoid port-specific steps and focus on waiting for readiness / preview URL output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md Removes port-memorization steps; updates the “no running instance” workflow (but currently drops the explicit “open preview URL” step).
packages/claude-plugin/skills/stories/SKILL.md Removes port-memorization steps and simplifies the preview-opening instructions.

Comment on lines +97 to 98
2. Wait for the terminal and storybook to be ready and show the preview URL in the terminal.
3. Make the preview browser visible to the user.
@codecov

codecov Bot commented Jun 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.78%. Comparing base (3db949d) to head (94b502c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files          67       67           
  Lines        2048     2048           
  Branches      578      578           
=======================================
  Hits         1634     1634           
  Misses        234      234           
  Partials      180      180           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@kasperpeulen
kasperpeulen marked this pull request as ready for review June 22, 2026 07:59
Copilot AI review requested due to automatic review settings June 22, 2026 07:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

1. Start the project's existing Storybook dev script as a background task from
the Storybook invocation directory
2. Wait for the terminal to show which port Storybook is running on and use that port to open the preview URL (e.g. `http://localhost:6006`) in the preview browser.
2. Wait for the terminal and storybook to be ready and show the preview URL in the terminal.
@huang-julien
huang-julien merged commit c61d3c6 into main Jun 22, 2026
16 checks passed
@huang-julien
huang-julien deleted the feat/remove_port branch June 22, 2026 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants