Repository navigation
feat(ade): remove port mention in skills - #303
Conversation
|
✅ Deploy Preview for storybook-mcp-self-host-example canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo ChangesStorybook Preview Startup Instruction Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Pull request overview
Removes instructions in Storybook “skills” docs that tell the agent to remember and reuse Storybook’s port, aligning the guidance with workflows that rely on the preview URL rather than a stored port.
Changes:
- Removed “save the port in working memory” guidance when detecting an existing Storybook instance.
- Updated “start Storybook” instructions to avoid port-specific steps and focus on waiting for readiness / preview URL output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md | Removes port-memorization steps; updates the “no running instance” workflow (but currently drops the explicit “open preview URL” step). |
| packages/claude-plugin/skills/stories/SKILL.md | Removes port-memorization steps and simplifies the preview-opening instructions. |
| 2. Wait for the terminal and storybook to be ready and show the preview URL in the terminal. | ||
| 3. Make the preview browser visible to the user. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 67 67
Lines 2048 2048
Branches 578 578
=======================================
Hits 1634 1634
Misses 234 234
Partials 180 180 ☔ View full report in Codecov by Harness. |
| 1. Start the project's existing Storybook dev script as a background task from | ||
| the Storybook invocation directory | ||
| 2. Wait for the terminal to show which port Storybook is running on and use that port to open the preview URL (e.g. `http://localhost:6006`) in the preview browser. | ||
| 2. Wait for the terminal and storybook to be ready and show the preview URL in the terminal. |
storybookjs/storybook#35235 (comment)
Summary by CodeRabbit
Release Notes