Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] fix return type of LCA_SqliteDatabase.select #2382

Merged
merged 4 commits into from
Dec 1, 2022
Merged

[MRG] fix return type of LCA_SqliteDatabase.select #2382

merged 4 commits into from
Dec 1, 2022

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Nov 30, 2022

Fixes #2380

@codecov
Copy link

codecov bot commented Nov 30, 2022 •
edited
Loading

Codecov Report

Merging #2382 (14d0fb4) into latest (dcd035d) will increase coverage by 8.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2382      +/-   ##
==========================================
+ Coverage   84.07%   92.19%   +8.12%     
==========================================
  Files         130      101      -29     
  Lines       15064    11522    -3542     
  Branches     2212     2212              
==========================================
- Hits        12665    10623    -2042     
+ Misses       2103      603    -1500     
  Partials      296      296
Flag Coverage Δ
python 92.19% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourmash/index/sqlite_index.py 92.16% <100.00%> (+0.08%) ⬆️
src/core/src/ffi/mod.rs
src/core/src/errors.rs
src/core/src/sketch/minhash.rs
src/core/src/ffi/index/mod.rs
src/core/src/encodings.rs
src/core/src/ffi/index/revindex.rs
src/core/src/ffi/utils.rs
src/core/src/ffi/storage.rs
src/core/src/signature.rs
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb ctb marked this pull request as draft November 30, 2022 15:13
@ctb ctb changed the title [MRG] fix return type of LCA_SqliteDatabase.select [WIP] fix return type of LCA_SqliteDatabase.select Nov 30, 2022
@ctb ctb changed the title [WIP] fix return type of LCA_SqliteDatabase.select [MRG] fix return type of LCA_SqliteDatabase.select Nov 30, 2022
@ctb ctb changed the title [MRG] fix return type of LCA_SqliteDatabase.select [MRG] fix return type of LCA_SqliteDatabase.select Nov 30, 2022
@ctb ctb marked this pull request as ready for review November 30, 2022 23:56
@ctb ctb enabled auto-merge (squash) November 30, 2022 23:56
@ctb
Copy link
Contributor Author

ctb commented Nov 30, 2022

Ready for review @sourmash-bio/devs !

bluegenes
bluegenes approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i think?

@ctb ctb merged commit 6f25fbf into latest Dec 1, 2022
@ctb ctb deleted the fix/sqlitedb_select branch December 1, 2022 23:35
@ctb ctb mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluegenes bluegenes bluegenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LCA_SqliteDatabase.select(...) incorrectly returns a SqliteIndex object
2 participants
@ctb @bluegenes