New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`LCA_SqliteDatabase.select(...)` incorrectly returns a `SqliteIndex` object #2380

Closed

ctb opened this issue Nov 29, 2022 · 0 comments · Fixed by #2382

Labels

bug

Contributor

ctb commented Nov 29, 2022

This incorrectly limits the return type functionality!

IMO the return from SqliteIndex.select(...) should construct the new object using self.__class__ rather than SqliteIndex.

The text was updated successfully, but these errors were encountered:

ctb added the bug label

ctb mentioned this issue

[MRG] fix return type of LCA_SqliteDatabase.select #2382

Merged

ctb closed this as completed in #2382

ctb added a commit that referenced this issue


          [MRG] fix return type of LCA_SqliteDatabase.select (#2382)

6f25fbf

Fixes #2380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment