This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Removes cap_accounts_data_len feature#35378
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Mar 1, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35378 +/- ##
========================================
Coverage 81.7% 81.7%
========================================
Files 834 834
Lines 224299 224814 +515
========================================
+ Hits 183361 183865 +504
- Misses 40938 40949 +11 |
CriesofCarrots
approved these changes
Mar 1, 2024
Contributor
CriesofCarrots
left a comment
There was a problem hiding this comment.
Lgtm. Could you please add to the PR description a link to the PR(s) that removed the code gated by this feature? I assume it's linked to the Feature Gate issue, but it is hard to tell which it might be.
t-nelson
approved these changes
Mar 1, 2024
Contributor
t-nelson
left a comment
There was a problem hiding this comment.
r+ tyera's pr/issue linkage suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
cap_accounts_data_lenfeature cannot and will not ever be activated. The code has been removed, but before that, it would introduce potential non-determinism. For more information, please refer to #27029Here's the original feature gate issue: #24135
Now all that remains is the feature itself, and can be safely removed.
PRs that removed code gated by this feature:
Summary of Changes
Remove the cap_accounts_data_len feature
Feature Gate Issue: #24135