This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Removes cap_accounts_data_size_per_block feature#35381
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Mar 1, 2024
Merged
Removes cap_accounts_data_size_per_block feature#35381brooksprumo merged 1 commit intosolana-labs:masterfrom
brooksprumo merged 1 commit intosolana-labs:masterfrom
Conversation
brooksprumo
added
the
feature-gate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35381 +/- ##
=========================================
- Coverage 81.8% 81.7% -0.1%
=========================================
Files 834 834
Lines 224815 224814 -1
=========================================
- Hits 183919 183874 -45
- Misses 40896 40940 +44 |
jeffwashington
requested review from
CriesofCarrots
and removed request for
jeffwashington
CriesofCarrots
approved these changes
Mar 1, 2024
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Same request as on #35378 : please add to the PR description a link to the PR(s) that removed the code gated by this feature before merge.
t-nelson
approved these changes
Mar 1, 2024
Contributor
t-nelson
left a comment
t-nelson
left a comment
There was a problem hiding this comment.
r+ tyera's pr/issue linkage suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
cap_accounts_data_size_per_blockfeature cannot and will not ever be activated. The code has been removed, but before that, it would introduce potential non-determinism. For more information, please refer to #27029Here's the original feature gate issue: #25517
Now all that remains is the feature itself, and can be safely removed.
PRs that removed code gated by this feature:
Summary of Changes
Remove the cap_accounts_data_size_per_block feature
Feature Gate Issue: #25517