This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove bank test_max_accounts_data_size_exceeded()#26772
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Aug 5, 2022
Conversation
Contributor
Author
Contributor
Author
This was referenced Aug 5, 2022
brooksprumo
deleted the
accounts-data-len/remove-bank-test_max_accounts_data_size_exceeded
branch
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
bank: remove test_max_accounts_data_size_exceeded()
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The accounts data size total limit will not be checked per instruction, so no instruction error will be thrown. When that change occurs, this test will no longer be useful/needed. Tests to the check the total accounts data size will be moved to ReplayStage.
See #26744 for full set of changes.
Part of #26439.
Summary of Changes
Remove test_max_accounts_data_size_exceeded()