This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove accounts data size checks in blockstore_processor#26776
Merged
brooksprumo merged 1 commit intosolana-labs:masterfrom Aug 5, 2022
Merged
Conversation
Contributor
Author
This was referenced Aug 5, 2022
xiangzhu70
pushed a commit
to xiangzhu70/solana
that referenced
this pull request
Aug 17, 2022
7 tasks
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
To fix #26439, checking the total accounts data size is moving to ReplayStage. It cannot be checked here in blockstore_processor, since entries are executed in parallel and thus non deterministic.
See #26744 for full code.
Summary of Changes
Remove checks and tests for the accounts data size.