This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Merged
Conversation
…et_instruction_keyed_accounts().
Codecov Report
@@ Coverage Diff @@
## master #22035 +/- ##
=========================================
+ Coverage 81.2% 81.4% +0.1%
=========================================
Files 552 517 -35
Lines 147607 145534 -2073
Branches 296 0 -296
=========================================
- Hits 119942 118482 -1460
+ Misses 27565 27052 -513
+ Partials 100 0 -100 |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
* Partial revert "Updates documentation around what needs to be passed in CPI. (#21633)" * Enforces the program_id being passed explicitly by removing it from get_instruction_keyed_accounts(). * instruction_accounts => instructions_account (cherry picked from commit ba8e158) # Conflicts: # program-runtime/src/invoke_context.rs
mergify Bot
added a commit
that referenced
this pull request
Dec 21, 2021
* Partial revert "Updates documentation around what needs to be passed in CPI. (#21633)" * Enforces the program_id being passed explicitly by removing it from get_instruction_keyed_accounts(). * instruction_accounts => instructions_account (cherry picked from commit ba8e158) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #21986 (comment)
It turns out that we can not remove the necessity of having
program_idin theaccount_metasandaccount_infosfor CPI just yet (as #20448 accidentally did). That is because ABIv1 still needs it to resolve the permissions ofkeyed_accountscorrectly in cases where multiplekeyed_accountsofprogram_idare being passed with different permissions.Summary of Changes
program_id, a thing that would not have worked before Refactor: process_instruction() #20448Fixes #21986