This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add test to enforce that program id account info for CPI is optional#22069
Merged
Lichtso merged 3 commits intosolana-labs:masterfrom Dec 23, 2021
Merged
Add test to enforce that program id account info for CPI is optional#22069Lichtso merged 3 commits intosolana-labs:masterfrom
Lichtso merged 3 commits intosolana-labs:masterfrom
Conversation
jstarry
force-pushed
the
optional-program-info
branch
3 times, most recently
from
67928dc to
fb9c5e3
Compare
Lichtso
previously approved these changes
Dec 23, 2021
Contributor
Lichtso
left a comment
Lichtso
left a comment
There was a problem hiding this comment.
I think you have to add an underscore here as well:
https://github.com/solana-labs/solana/pull/22069/files#diff-cab9f38041ae98bb2e8a51d9ff91cdb842a145f12c9c15e11d9978d359ea4794L11
Otherwise looking good, and thanks again!
jstarry
force-pushed
the
optional-program-info
branch
from
fb9c5e3 to
3764375
Compare
mergify
Bot
dismissed
Lichtso’s stale review
Pull request has been modified.
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## master #22069 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 518 518
Lines 145734 145764 +30
=========================================
- Hits 118554 118530 -24
- Misses 27180 27234 +54 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Seems that there isn't an explicit test that demonstrates that the program id account info is not required for CPI's.
Summary of Changes
Fixes #