Fix #21397

[Lichtso]

Problem

#20448 changed how the program keyed_accounts are popped from the front from using InvokeContext::remove_first_keyed_account() to instead using a parameter called first_instruction_account.
However, while the change was applied to most of the program runtime, CPI was left out.
Luckily, InvokeContextStackFrame::number_of_program_accounts is set to program_indices.len() (which is the same value as first_instruction_account + 1) in InvokeContext::push() so we can use that in CPI without routing first_instruction_account explicitly as a parameter.

Summary of Changes

Adds InvokeContext::get_instruction_keyed_accounts() to skip first_instruction_account keyed_accounts in CPI.

Fixes #21397

[mergify]

automerge label removed due to a CI failure

[codecov]

Codecov Report

Merging #21535 (8e9a5af) into master (b78f5b6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #21535   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         505      505           
  Lines      141409   141416    +7     
=======================================
+ Hits       115506   115515    +9     
+ Misses      25903    25901    -2     

[jstarry]

@Lichtso why do you subtract 1 here?

[Lichtso]

Because the number_of_program_accounts - 1 is first_instruction_account.
Or in other words number_of_program_accounts is first_instruction_account + 1.

first_instruction_account is actually the index of the program_id of that instruction, see:

solana/program-runtime/src/invoke_context.rs

Line 132 in c9bfc99

.get(self.number_of_program_accounts.saturating_sub(1))

[jstarry]

This change is not working for me while developing a native program. I'm calling get_instruction_keyed_accounts but the first account is the program account.

[jstarry]

If the intent is to also include the instruction program keyed account in this list, can you update the comment to say so? The comment right now indicates that this will return a list of instruction account inputs (excluding the program account)

[Lichtso]

Yes, it includes the program_id (at index 0).
And good point, I will update the comment.

[jstarry]

Thanks! It would be really helpful if the comment made it clearer what the breakdown of invoke context keyed accounts is and when it's appropriate to use get_instruction_keyed_accounts over get_keyed_accounts.