This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Updates documentation around CPI and InvokeContext::get_keyed_accounts#21633
Merged
Lichtso merged 1 commit intosolana-labs:masterfrom Dec 6, 2021
Merged
Conversation
jstarry
reviewed
Dec 6, 2021
Lichtso
force-pushed
the
docs/cpi_first_instruction_account
branch
from
46e6217 to
82b5a81
Compare
jstarry
approved these changes
Dec 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #21633 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 510 510
Lines 142504 142504
=========================================
- Hits 116416 116405 -11
- Misses 26088 26099 +11 |
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Dec 20, 2021
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Dec 20, 2021
Merged
Lichtso
added a commit
that referenced
this pull request
Dec 21, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
* Partial revert "Updates documentation around what needs to be passed in CPI. (#21633)" * Enforces the program_id being passed explicitly by removing it from get_instruction_keyed_accounts(). * instruction_accounts => instructions_account (cherry picked from commit ba8e158) # Conflicts: # program-runtime/src/invoke_context.rs
mergify Bot
added a commit
that referenced
this pull request
Dec 21, 2021
* Partial revert "Updates documentation around what needs to be passed in CPI. (#21633)" * Enforces the program_id being passed explicitly by removing it from get_instruction_keyed_accounts(). * instruction_accounts => instructions_account (cherry picked from commit ba8e158) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See discussion here: https://github.com/solana-labs/solana/pull/21535/files
Summary of Changes
Updates the documentation around:
InvokeContext::get_keyed_accounts()andInvokeContext::get_instruction_keyed_accounts()differFixes #