This repository was archived by the owner on Jan 22, 2025. It is now read-only.
removes first_coding_index from erasure recovery code#16646
Merged
behzadnouri merged 1 commit intosolana-labs:masterfrom Apr 23, 2021
Merged
removes first_coding_index from erasure recovery code#16646behzadnouri merged 1 commit intosolana-labs:masterfrom
behzadnouri merged 1 commit intosolana-labs:masterfrom
Conversation
behzadnouri
changed the title
Codecov Report
@@ Coverage Diff @@
## master #16646 +/- ##
========================================
Coverage 82.9% 82.9%
========================================
Files 418 416 -2
Lines 115893 115463 -430
========================================
- Hits 96183 95828 -355
+ Misses 19710 19635 -75 |
behzadnouri
force-pushed
the
rm-first-coding-index
branch
from
edba3e5 to
e05afea
Compare
behzadnouri
force-pushed
the
rm-first-coding-index
branch
from
2aec979 to
3180cfd
Compare
behzadnouri
force-pushed
the
rm-first-coding-index
branch
from
3180cfd to
077278e
Compare
carllin
reviewed
Apr 22, 2021
| /// Which erasure set in the slot this is | ||
| pub set_index: u64, | ||
| /// First coding index in the FEC set | ||
| pub first_coding_index: u64, |
Contributor
There was a problem hiding this comment.
hmmm since these are stored/fetched from Rocks, is this going to cause compatibility issues if we try to fetch old ErasureMeta's?
Contributor
Author
There was a problem hiding this comment.
you are right. fixed
behzadnouri
force-pushed
the
rm-first-coding-index
branch
from
077278e to
874eee2
Compare
first_coding_index is the same as the set_index and is so redundant: https://github.com/solana-labs/solana/blob/37b8587d4/ledger/src/blockstore_meta.rs#L49-L60
behzadnouri
force-pushed
the
rm-first-coding-index
branch
from
874eee2 to
724d95c
Compare
carllin
approved these changes
Apr 22, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Apr 23, 2021
first_coding_index is the same as the set_index and is so redundant: https://github.com/solana-labs/solana/blob/37b8587d4/ledger/src/blockstore_meta.rs#L49-L60 (cherry picked from commit 0319414)
mergify Bot
added a commit
that referenced
this pull request
Apr 23, 2021
first_coding_index is the same as the set_index and is so redundant: https://github.com/solana-labs/solana/blob/37b8587d4/ledger/src/blockstore_meta.rs#L49-L60 (cherry picked from commit 0319414) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Closed
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Dec 6, 2021
solana-labs#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a dedicated field to represent.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Dec 6, 2021
solana-labs#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Dec 8, 2021
solana-labs#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Dec 9, 2021
solana-labs#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Dec 9, 2021
solana-labs#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent.
behzadnouri
added a commit
that referenced
this pull request
Dec 10, 2021
#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent.
mergify Bot
added a commit
that referenced
this pull request
Dec 10, 2021
#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
mergify Bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) # Conflicts: # ledger/src/blockstore.rs
mergify Bot
added a commit
that referenced
this pull request
Feb 3, 2022
…2912) * adds back ErasureMeta::first_coding_index field (#21623) #16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) # Conflicts: # ledger/src/blockstore.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
first_coding_indexis the same as theset_indexand is so redundant:https://github.com/solana-labs/solana/blob/37b8587d4/ledger/src/blockstore_meta.rs#L49-L60
Summary of Changes
first_coding_index