This repository was archived by the owner on Jan 22, 2025. It is now read-only.
adds back ErasureMeta::first_coding_index field (backport #21623)#22912
Merged
mergify[bot] merged 2 commits intov1.8from Feb 3, 2022
Merged
adds back ErasureMeta::first_coding_index field (backport #21623)#22912mergify[bot] merged 2 commits intov1.8from
mergify[bot] merged 2 commits intov1.8from
Conversation
#16646 removed first_coding_index since the field is currently redundant and always equal to fec_set_index. However, with upcoming changes to erasure coding schema, this will no longer be the same as fec_set_index and so requires a separate field to represent. (cherry picked from commit 49ba09b) # Conflicts: # ledger/src/blockstore.rs
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
Contributor
Author
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## v1.8 #22912 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 464 464
Lines 131709 131738 +29
=======================================
+ Hits 107555 107598 +43
+ Misses 24154 24140 -14 |
Contributor
|
This PR has been automatically locked since there has not been any activity in past 14 days after it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #21623 done by Mergify.
Cherry-pick of 49ba09b has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com