This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add offline and fee-payer utilities to CLI vote module#21579
Merged
CriesofCarrots merged 10 commits intosolana-labs:masterfrom Dec 6, 2021
Merged
Add offline and fee-payer utilities to CLI vote module#21579CriesofCarrots merged 10 commits intosolana-labs:masterfrom
CriesofCarrots merged 10 commits intosolana-labs:masterfrom
Conversation
added 10 commits
December 3, 2021 20:19
…cannot perform account state queries as in CloseVoteAccount
CriesofCarrots
force-pushed
the
vote-offline
branch
from
4d5c0ea to
0a7ec58
Compare
Codecov Report
@@ Coverage Diff @@
## master #21579 +/- ##
========================================
Coverage 81.6% 81.6%
========================================
Files 508 509 +1
Lines 142340 142932 +592
========================================
+ Hits 116155 116682 +527
- Misses 26185 26250 +65 |
t-nelson
approved these changes
Dec 6, 2021
Contributor
t-nelson
left a comment
t-nelson
left a comment
There was a problem hiding this comment.
that must've been monotonous. lgtm!
mergify Bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
* create-vote-account: add offline, nonce, fee_payer capabilities * vote-authorize: add offline, nonce, fee-payer * vote-update-things: add offline, nonce, fee-payer * withdraw-vote: add offline, nonce, fee-payer * close-vote-acct: add fee-payer * Allow WithdrawVoteAccount to empty account, since offline operations cannot perform account state queries as in CloseVoteAccount * Fix lint * Update offline-signing docs * Add some parse unit tests * Add offline integration test (cherry picked from commit 873fe81) # Conflicts: # cli/src/cli.rs # cli/src/vote.rs # cli/tests/vote.rs
mergify Bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
* create-vote-account: add offline, nonce, fee_payer capabilities * vote-authorize: add offline, nonce, fee-payer * vote-update-things: add offline, nonce, fee-payer * withdraw-vote: add offline, nonce, fee-payer * close-vote-acct: add fee-payer * Allow WithdrawVoteAccount to empty account, since offline operations cannot perform account state queries as in CloseVoteAccount * Fix lint * Update offline-signing docs * Add some parse unit tests * Add offline integration test (cherry picked from commit 873fe81)
mergify Bot
added a commit
that referenced
this pull request
Dec 7, 2021
* create-vote-account: add offline, nonce, fee_payer capabilities * vote-authorize: add offline, nonce, fee-payer * vote-update-things: add offline, nonce, fee-payer * withdraw-vote: add offline, nonce, fee-payer * close-vote-acct: add fee-payer * Allow WithdrawVoteAccount to empty account, since offline operations cannot perform account state queries as in CloseVoteAccount * Fix lint * Update offline-signing docs * Add some parse unit tests * Add offline integration test (cherry picked from commit 873fe81) Co-authored-by: Tyera Eulberg <teulberg@gmail.com>
mergify Bot
added a commit
that referenced
this pull request
Dec 7, 2021
…) (#21648) * Add offline and fee-payer utilities to CLI vote module (#21579) * create-vote-account: add offline, nonce, fee_payer capabilities * vote-authorize: add offline, nonce, fee-payer * vote-update-things: add offline, nonce, fee-payer * withdraw-vote: add offline, nonce, fee-payer * close-vote-acct: add fee-payer * Allow WithdrawVoteAccount to empty account, since offline operations cannot perform account state queries as in CloseVoteAccount * Fix lint * Update offline-signing docs * Add some parse unit tests * Add offline integration test (cherry picked from commit 873fe81) # Conflicts: # cli/src/cli.rs # cli/src/vote.rs # cli/tests/vote.rs * Fix conflicts Co-authored-by: Tyera Eulberg <teulberg@gmail.com> Co-authored-by: Tyera Eulberg <tyera@solana.com>
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…ort solana-labs#21579) (solana-labs#21648)" This reverts commit 1ab8c01.
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…e (backport solana-labs#21579) (solana-labs#21648)"" This reverts commit 64c5e7d.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Validators would like to withdraw from their vote accounts without using their withdraw authorities on a networked machine, but the solana-cli doesn't support offline signing for
solana withdraw-vote-account.Summary of Changes
solana close-vote-account(could be implemented for that command too, but would require the user to know the current account balance, so I decided to kick that can until there's demand)Todo: