Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Add offline and fee-payer utilities to CLI vote module (backport #21579)#21648

Merged
mergify[bot] merged 2 commits intov1.8from
mergify/bp/v1.8/pr-21579
Dec 7, 2021
Merged

Add offline and fee-payer utilities to CLI vote module (backport #21579)#21648
mergify[bot] merged 2 commits intov1.8from
mergify/bp/v1.8/pr-21579

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Dec 6, 2021

This is an automatic backport of pull request #21579 done by Mergify.
Cherry-pick of 873fe81 has failed:

On branch mergify/bp/v1.8/pr-21579
Your branch is up to date with 'origin/v1.8'.

You are currently cherry-picking commit 873fe81bc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cli/tests/stake.rs
	modified:   docs/src/offline-signing.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   cli/src/cli.rs
	both modified:   cli/src/vote.rs
	both modified:   cli/tests/vote.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* create-vote-account: add offline, nonce, fee_payer capabilities

* vote-authorize: add offline, nonce, fee-payer

* vote-update-things: add offline, nonce, fee-payer

* withdraw-vote: add offline, nonce, fee-payer

* close-vote-acct: add fee-payer

* Allow WithdrawVoteAccount to empty account, since offline operations cannot perform account state queries as in CloseVoteAccount

* Fix lint

* Update offline-signing docs

* Add some parse unit tests

* Add offline integration test

(cherry picked from commit 873fe81)

# Conflicts:
#	cli/src/cli.rs
#	cli/src/vote.rs
#	cli/tests/vote.rs
@mergify mergify Bot added conflicts automerge Merge this Pull Request automatically once CI passes labels Dec 6, 2021
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Dec 6, 2021

automerge label removed due to a CI failure

@mergify mergify Bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 6, 2021
@mergify mergify Bot added the automerge Merge this Pull Request automatically once CI passes label Dec 7, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2021

Codecov Report

Merging #21648 (df81cd7) into v1.8 (4d3352e) will decrease coverage by 0.1%.
The diff coverage is 77.1%.

@@            Coverage Diff            @@
##             v1.8   #21648     +/-   ##
=========================================
- Coverage    81.7%    81.6%   -0.2%     
=========================================
  Files         456      459      +3     
  Lines      129990   130369    +379     
=========================================
+ Hits       106240   106413    +173     
- Misses      23750    23956    +206     

@mergify mergify Bot merged commit 1ab8c01 into v1.8 Dec 7, 2021
@mergify mergify Bot deleted the mergify/bp/v1.8/pr-21579 branch December 7, 2021 02:09
t-nelson added a commit to t-nelson/solana that referenced this pull request Dec 13, 2021
tao-stones pushed a commit that referenced this pull request Dec 13, 2021
CriesofCarrots pushed a commit to CriesofCarrots/solana that referenced this pull request Dec 16, 2021
CriesofCarrots pushed a commit that referenced this pull request Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant