This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add offline and fee-payer utilities to CLI vote module (backport #21579)#21648
Merged
mergify[bot] merged 2 commits intov1.8from Dec 7, 2021
Merged
Add offline and fee-payer utilities to CLI vote module (backport #21579)#21648mergify[bot] merged 2 commits intov1.8from
mergify[bot] merged 2 commits intov1.8from
Conversation
* create-vote-account: add offline, nonce, fee_payer capabilities * vote-authorize: add offline, nonce, fee-payer * vote-update-things: add offline, nonce, fee-payer * withdraw-vote: add offline, nonce, fee-payer * close-vote-acct: add fee-payer * Allow WithdrawVoteAccount to empty account, since offline operations cannot perform account state queries as in CloseVoteAccount * Fix lint * Update offline-signing docs * Add some parse unit tests * Add offline integration test (cherry picked from commit 873fe81) # Conflicts: # cli/src/cli.rs # cli/src/vote.rs # cli/tests/vote.rs
Contributor
Author
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## v1.8 #21648 +/- ##
=========================================
- Coverage 81.7% 81.6% -0.2%
=========================================
Files 456 459 +3
Lines 129990 130369 +379
=========================================
+ Hits 106240 106413 +173
- Misses 23750 23956 +206 |
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…ort solana-labs#21579) (solana-labs#21648)" This reverts commit 1ab8c01.
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…e (backport solana-labs#21579) (solana-labs#21648)"" This reverts commit 64c5e7d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #21579 done by Mergify.
Cherry-pick of 873fe81 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com