This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Reject vote withdraws that create non-rent-exempt accounts#21639
Merged
jstarry merged 2 commits intosolana-labs:masterfrom Dec 6, 2021
Merged
Reject vote withdraws that create non-rent-exempt accounts#21639jstarry merged 2 commits intosolana-labs:masterfrom
jstarry merged 2 commits intosolana-labs:masterfrom
Conversation
Contributor
|
Coincidentally just came across the the cli-side checks for this here and it was on my list to ensure rent-exemption was programmatically enforced. Thanks! |
jstarry
requested review from
CriesofCarrots
and removed request for
t-nelson
CriesofCarrots
previously approved these changes
Dec 6, 2021
Contributor
CriesofCarrots
left a comment
CriesofCarrots
left a comment
There was a problem hiding this comment.
Yep, lgtm! Thanks again
Contributor
|
I think we may want this on v1.8 later, if we move toward no rent-paying accounts. |
jstarry
added
v1.8
automerge
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify
Bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
mergify
Bot
removed
the
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Reject vote withdraws that create non-rent-exempt accounts * fix mocked instruction test (cherry picked from commit e123883) # Conflicts: # program-runtime/src/invoke_context.rs # programs/vote/src/vote_instruction.rs # sdk/src/feature_set.rs
mergify Bot
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Reject vote withdraws that create non-rent-exempt accounts * fix mocked instruction test (cherry picked from commit e123883) # Conflicts: # sdk/src/feature_set.rs
mergify Bot
added a commit
that referenced
this pull request
Dec 7, 2021
…21639) (#21645) * Reject vote withdraws that create non-rent-exempt accounts (#21639) * Reject vote withdraws that create non-rent-exempt accounts * fix mocked instruction test (cherry picked from commit e123883) # Conflicts: # sdk/src/feature_set.rs * resolve conflicts Co-authored-by: Justin Starry <justin@solana.com>
jstarry
added a commit
that referenced
this pull request
Dec 7, 2021
…21639) (#21644) * Reject vote withdraws that create non-rent-exempt accounts (#21639) * Reject vote withdraws that create non-rent-exempt accounts * fix mocked instruction test (cherry picked from commit e123883) # Conflicts: # program-runtime/src/invoke_context.rs # programs/vote/src/vote_instruction.rs # sdk/src/feature_set.rs * resolve conflicts * fix old rust issue Co-authored-by: Justin Starry <justin@solana.com>
t-nelson
added a commit
to t-nelson/solana
that referenced
this pull request
Dec 13, 2021
…ackport solana-labs#21639) (solana-labs#21644)" This reverts commit 83e0144.
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…ounts (backport solana-labs#21639) (solana-labs#21644)"" This reverts commit ae11cc3.
Closed
This was referenced Jan 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The remaining balance after a vote withdraw is not checked to see if it meets the rent exempt threshold.
Summary of Changes
Fixes #