This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Cli: Restore withdraw-from-vote-account ALL behavior#21854
Merged
CriesofCarrots merged 1 commit intosolana-labs:masterfrom Dec 14, 2021
Merged
Cli: Restore withdraw-from-vote-account ALL behavior#21854CriesofCarrots merged 1 commit intosolana-labs:masterfrom
CriesofCarrots merged 1 commit intosolana-labs:masterfrom
Conversation
…ke behavior clearer
CriesofCarrots
commented
Dec 13, 2021
| destination_account_pubkey: pubkey, | ||
| withdraw_authority: 0, | ||
| withdraw_amount: SpendAmount::All, | ||
| withdraw_amount: SpendAmount::RentExempt, |
Contributor
Author
There was a problem hiding this comment.
This difference gets called out explicitly now
mvines
approved these changes
Dec 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #21854 +/- ##
=========================================
- Coverage 81.3% 81.3% -0.1%
=========================================
Files 516 516
Lines 144185 144206 +21
=========================================
+ Hits 117237 117250 +13
- Misses 26948 26956 +8 |
CriesofCarrots
added a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 16, 2021
…ke behavior clearer (solana-labs#21854)
CriesofCarrots
added a commit
that referenced
this pull request
Dec 17, 2021
…ke behavior clearer (#21854)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#21579 used existing apis to implement offline handling. However, this broke the ALL special case in
solana withdraw-from-vote-account.Summary of Changes
Fixes #21815
This needs to be backported to v1.8, if/when #21648 gets un-reverted