Combine RpcResponseTransformer and RpcResponseTransformerFor

[lorisleiva]

This PR combines the RpcResponseTransformer and RpcResponseTransformerFor types by using an optional type parameter.

Initially, RpcResponseTransformer was defining a generic function (as opposed to a generic type that applies its type parameter to the function). However, this was only needed in the rpc-api file to do:

config.responseTransformer<TypeExpectationHere>;

The same can be achieved using:

config.responseTransformer as RpcResponseTransformer<TypeExpectationHere>;

Without loosening any types as config.responseTransformer<T> was equivalent to a type-cast.

This makes it less tedious to define response transformers as we don't have to always cast our return type to an abstract type T even when we know the real return type.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 48fa39a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[lorisleiva]

• Split RpcResponse into RpcResponse and RpcTransportResponse #3170
• Add toPayload and toText optional functions to RpcRequest #3168
• Add more response transformers #3163
• Combine RpcResponseTransformer and RpcResponseTransformerFor #3162 👈
• Add more request transformers #3161
• Refactor fix for issue 479 as a transformer #3160
• Add getDefaultCommitmentRequestTransformer helper #3159
• Use RpcRequestTransformer type parameter on request argument #3158
• Update RPC APIs to use new types #3150
• Move types outside of rpc-request file #3149
• Update RPC transports to use new types #3148
• Add new RpcRequest, RpcResponse types and their transformer types #3147
• Rename RpcRequest to RpcApiRequestPlan #3146
• Rename RpcResponse to RpcResponseData #3145
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite

[steveluscher]

[lorisleiva]

Merge activity

• Sep 1, 2:06 PM EDT: @lorisleiva started a stack merge that includes this pull request via Graphite.
• Sep 1, 2:36 PM EDT: Graphite rebased this pull request as part of a merge.
• Sep 1, 2:37 PM EDT: @lorisleiva merged this pull request with Graphite.

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.