Update RPC transports to use new types #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 700d020 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Aug 23, 2024
This was referenced Aug 23, 2024
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
4 times, most recently
from
74da6c5
to
93d3a29
Compare
buffalojoec
reviewed
Aug 23, 2024
|
|
||
| type CoalescedRequest = { | ||
| readonly abortController: AbortController; | ||
| numConsumers: number; | ||
| readonly responsePromise: Promise<unknown>; | ||
| readonly responsePromise: Promise<RpcResponse | undefined>; |
There was a problem hiding this comment.
Does this need to be | undefined?
There was a problem hiding this comment.
That's already the current type definition of the coalescer. It just didn't show before because unknown | undefined is equivalent to unknown.
lorisleiva
force-pushed
the
loris/add-rpc-request-response-types
branch
from
e236173
to
1d66210
Compare
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
from
93d3a29
to
64e933c
Compare
lorisleiva
force-pushed
the
loris/add-rpc-request-response-types
branch
from
1d66210
to
1e437d1
Compare
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
from
64e933c
to
4ad7ad4
Compare
lorisleiva
force-pushed
the
loris/add-rpc-request-response-types
branch
from
1e437d1
to
130c829
Compare
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
from
4ad7ad4
to
9aa2b28
Compare
lorisleiva
force-pushed
the
loris/add-rpc-request-response-types
branch
from
130c829
to
f240c65
Compare
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
from
9aa2b28
to
607325f
Compare
lorisleiva
force-pushed
the
loris/add-rpc-request-response-types
branch
from
f240c65
to
6c3ae7a
Compare
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
2 times, most recently
from
eeccea5
to
5f13964
Compare
This was referenced Aug 26, 2024
This was referenced Aug 27, 2024
lorisleiva
force-pushed
the
loris/add-rpc-request-response-types
branch
from
6c3ae7a
to
925398e
Compare
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
from
5f13964
to
dc06db4
Compare
Merge activity
|
lorisleiva
changed the base branch from
loris/add-rpc-request-response-types
to
graphite-base/3148
lorisleiva
force-pushed
the
loris/update-rpc-transport
branch
from
dc06db4
to
700d020
Compare
This was referenced Sep 1, 2024
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the RPC Transport layer by making sure they return the new
RpcResponseinterface instead of returning the parsed response data directly.