Refactor fix for issue 479 as a transformer #3160
Conversation
|
There was a problem hiding this comment.
Do we need this transformer anymore? The fix was backported to 1.18, which is the version the RPC is running on mainnet-beta.
lorisleiva
force-pushed
the
loris/add-get-default-commitment-request-transformer
branch
from
655a250
to
891c8c0
Compare
lorisleiva
force-pushed
the
loris/refactor-fix-479
branch
from
d29ef2d
to
6a8c5ee
Compare
|
@buffalojoec Oh I didn't know this. In this case it's probably safe to remove and I'll add a PR to this stack to do this. Cc @steveluscher to double-check it's okay to remove? |
| @@ -27,29 +27,34 @@ export function getDefaultRequestTransformerForSolanaRpc(config?: RequestTransfo | |||
| const initialState = { | |||
| keyPath: [], | |||
| }; | |||
| const patchedRequest = { methodName, params: traverse(rawParams, initialState) as T }; | |||
| const patchedRequest = { methodName, params: traverse(rawParams, initialState) }; | |||
| return pipe( | |||
| patchedRequest, | |||
| getDefaultCommitmentRequestTransformer({ | |||
| defaultCommitment, | |||
| optionsObjectPositionByMethod: OPTIONS_OBJECT_POSITION_BY_METHOD, | |||
| }), | |||
| // FIXME Remove when https://github.com/anza-xyz/agave/pull/483 is deployed. | |||
There was a problem hiding this comment.
Side note: pretty sure we can delete this whole entire thing, because this was released in 1.18.13 and >=1.18.15 is the network now.
Merge activity
|
lorisleiva
changed the base branch from
loris/add-get-default-commitment-request-transformer
to
graphite-base/3160
lorisleiva
force-pushed
the
loris/refactor-fix-479
branch
from
6a8c5ee
to
96a54e8
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This PR refactors the internal fix for issue 479 as a request transformer called
getFixForIssue479RequestTransformer. this is part of a series of effort to extract all transformers into their own helper so the default transformer can be a simple composition of all of them.