Repository navigation
chore: add release 1.3.2 - #780
Conversation
github-actions
Bot
added
python-bindings
📝 WalkthroughWalkthroughThis PR updates SMG-related GitHub Actions workflow defaults from v1.3.1 → v1.3.2, bumps multiple package versions (bindings and model_gateway) from 1.3.1 → 1.3.2, increments Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version bump across several core components and language bindings, preparing the project for a new release, version 1.3.2. It ensures all relevant packages reflect the latest development state and maintain consistent versioning. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates version numbers in Cargo.toml and pyproject.toml files to prepare for release 1.3.2. The smg package and its bindings are bumped to version 1.3.2, and the openai-protocol package is bumped to 1.4.1. The changes are consistent across the workspace.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release-trtllm-docker.yml:
- Line 59: The smg_commit assignment contains a dead branch for pull_request;
update the smg_commit expression to remove the unreachable "github.event_name ==
'pull_request' && 'main' ||" portion and default purely to the input or literal
(e.g. change smg_commit to use ${{ inputs.smg_commit || 'v1.3.2' }}). Locate the
smg_commit key in the workflow and replace the current ternary-like expression
so it no longer references pull_request and simply falls back to
inputs.smg_commit or 'v1.3.2'.
In @.github/workflows/release-vllm-docker.yml:
- Line 59: The conditional expression assigning smg_commit contains a dead
`github.event_name == 'pull_request' && 'main'` branch; remove that part and
simplify the assignment to fall back to the input or literal default (i.e.,
evaluate to inputs.smg_commit or 'v1.3.2') so the value isn't predicated on a
non-existent trigger; locate the smg_commit assignment and replace the
ternary/guard with the simpler fallback expression, or alternatively add an
explicit pull_request trigger and matching dry_run/input handling to mirror
release-sglang-docker.yml if you actually need pull_request behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9c6f31df-820f-4220-a2d5-9f0f2c4a5ca4
📒 Files selected for processing (10)
.github/workflows/release-sglang-docker.yml.github/workflows/release-trtllm-docker.yml.github/workflows/release-vllm-docker.ymlCargo.tomlbindings/golang/Cargo.tomlbindings/python/Cargo.tomlbindings/python/pyproject.tomlcrates/grpc_client/python/pyproject.tomlcrates/protocols/Cargo.tomlmodel_gateway/Cargo.toml
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f75e0c15a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e75363087
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| engine_commit: ${{ inputs.sglang_commit || 'latest' }} | ||
| smg_repo: ${{ inputs.smg_repo || 'https://github.com/lightseekorg/smg' }} | ||
| smg_commit: ${{ github.event_name == 'pull_request' && 'main' || inputs.smg_commit || 'v1.3.1' }} | ||
| smg_commit: ${{ github.event_name == 'pull_request' && 'main' || inputs.smg_commit || 'v1.3.2' }} |
There was a problem hiding this comment.
For push events (which these workflows trigger on when bindings/python/pyproject.toml changes), inputs.smg_commit is unset, so this resolves to v1.3.2; however, the documented release flow tags only after merge (docs/contributing/development.md, steps 3–4), so the first post-merge run can reference a non-existent ref and fail when docker/engine.Dockerfile executes git checkout "${SMG_COMMIT}". Fresh evidence in this commit is that the same fallback was updated in release-trtllm-docker.yml:59 and release-vllm-docker.yml:59, so all three release image workflows are affected.
Useful? React with 👍 / 👎.
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
.github/workflows/release-vllm-docker.yml (1)
59-59: 🧹 Nitpick | 🔵 TrivialDead
pull_requestguard still present.The condition
github.event_name == 'pull_request' && 'main'is dead code — this workflow only triggers onpushandworkflow_dispatch(lines 10-15), sogithub.event_namewill never be'pull_request'.While the version bump to
v1.3.2is correct, consider simplifying as previously suggested:♻️ Suggested simplification
- smg_commit: ${{ github.event_name == 'pull_request' && 'main' || inputs.smg_commit || 'v1.3.2' }} + smg_commit: ${{ inputs.smg_commit || 'v1.3.2' }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release-vllm-docker.yml at line 59, The smg_commit expression contains a dead github.event_name == 'pull_request' && 'main' guard; remove that branch and simplify the expression so it falls back to the input or the default version only (replace the current smg_commit assignment with a simple fallback that uses inputs.smg_commit or 'v1.3.2'), updating the line that defines smg_commit accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/workflows/release-vllm-docker.yml:
- Line 59: The smg_commit expression contains a dead github.event_name ==
'pull_request' && 'main' guard; remove that branch and simplify the expression
so it falls back to the input or the default version only (replace the current
smg_commit assignment with a simple fallback that uses inputs.smg_commit or
'v1.3.2'), updating the line that defines smg_commit accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: fcb35a64-5844-4c90-a678-d0e37d6826b8
📒 Files selected for processing (10)
.github/workflows/release-sglang-docker.yml.github/workflows/release-trtllm-docker.yml.github/workflows/release-vllm-docker.ymlCargo.tomlbindings/golang/Cargo.tomlbindings/python/Cargo.tomlbindings/python/pyproject.tomlcrates/grpc_client/python/pyproject.tomlcrates/protocols/Cargo.tomlmodel_gateway/Cargo.toml
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
1 participant
Description
Problem
Solution
Changes
Test Plan
Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspassesSummary by CodeRabbit