Repository navigation
chore(release): bump version to 1.3.1 - #767
Conversation
What changed: - model_gateway/Cargo.toml: 1.3.0 → 1.3.1 - bindings/python/Cargo.toml: 1.3.0 → 1.3.1 - bindings/python/pyproject.toml: 1.3.0 → 1.3.1 - bindings/golang/Cargo.toml: 1.3.0 → 1.3.1 - .github/workflows/release-sglang-docker.yml: v1.3.0 → v1.3.1 - .github/workflows/release-vllm-docker.yml: v1.3.0 → v1.3.1 - .github/workflows/release-trtllm-docker.yml: v1.3.0 → v1.3.1 - scripts/check_release_versions.sh: remove build-engine from SMG_VERSION_SYNC (uses branch ref 'main', not version tag) Why: patch release for minor fixes since v1.3.0. Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request bumps the SMG version from v1.3.0 to v1.3.1 across package manifests, Docker release workflows, and CI/CD configuration. The changes include updating default SMG commit references in three GitHub Actions workflows, incrementing version strings in Cargo.toml and pyproject.toml files, and removing one entry from the release version synchronization check script. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a patch release, incrementing the project version from 1.3.0 to 1.3.1 across various configuration files and CI/CD workflows. It ensures consistency in versioning throughout the codebase and refines the version synchronization script by removing an irrelevant entry. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the v1.3.1 patch release by bumping version numbers. The versions in bindings/golang/Cargo.toml, bindings/python/Cargo.toml, bindings/python/pyproject.toml, and model_gateway/Cargo.toml have been correctly updated from 1.3.0 to 1.3.1. The modification to scripts/check_release_versions.sh to remove an item from version synchronization is also correct based on the reasoning provided.
However, there is a critical discrepancy. The pull request description states that release-sglang-docker.yml, release-vllm-docker.yml, and release-trtllm-docker.yml were also updated. These changes are missing from the pull request. Please update the pull request to include the changes to these files to ensure a consistent and successful release.
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
Summary
Patch release v1.3.1 — bumps all version references from 1.3.0 to 1.3.1.
What changed
build-enginefromSMG_VERSION_SYNC— it usesdefault: 'main'(branch ref), not a version tag, so it should not be version-syncedHow
Generated via
VERSION_OVERRIDE=1.3.1 ./scripts/check_release_versions.sh(from #764).Test plan
make check-versions VERSION_OVERRIDE=1.3.1reports all versions consistentcargo build --releasesucceedsSummary by CodeRabbit