Repository navigation
chore: bump versions for v1.3.0 release - #760
Conversation
Bump all crate and artifact versions for the v1.3.0 release: - openai-protocol: v1.3.0 → v1.4.0 (minor, protocol changes) - smg-mesh: v1.1.2 → v1.2.0 (minor, mesh feature changes) - smg-grpc-client: v1.3.0 → v1.4.0 (minor, gRPC client changes) - openapi-gen: v0.1.0 → v0.1.1 (patch) - smg: v1.2.0 → v1.3.0 (minor, Messages API support) - smg-python: v1.2.0 → v1.3.0 (sync with smg) - smg-golang: v1.2.0 → v1.3.0 (sync with smg) - Docker workflows: v1.2.0 → v1.3.0 (sync with smg) - Workspace Cargo.toml: sync dependency versions Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
📝 WalkthroughWalkthroughCoordinated version bumps across workspace crates and bindings plus updates to Docker release workflows' SMG commit defaults; several GitHub Actions now resolve Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version numbers across various crates and language bindings in preparation for the v1.3.0 release. The version increments reflect the integration of new features such as Messages API gRPC support, mesh high-availability synchronization, WebRTC plumbing, and MCP extraction, ensuring all components are aligned with the latest developments. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly bumps versions for multiple crates for the v1.3.0 release, and the changes in the Cargo.toml and pyproject.toml files are consistent. However, there's a critical omission: the PR description mentions that 'Docker workflows' were updated from v1.2.0 to v1.3.0, but the corresponding workflow files (e.g., .github/workflows/release-sglang-docker.yml, .github/workflows/release-vllm-docker.yml) are not part of this pull request. For a release PR, it's crucial that all version references are updated consistently. Please add the missing workflow file changes to ensure the release process uses the correct versions.
Docker image builds fail during PRs because smg_commit defaults to the version tag (e.g. v1.3.0) which doesn't exist yet. Fix by: - _build-engine-image.yml: change default smg_commit from version tag to 'main' - release-*-docker.yml: override smg_commit to 'main' when triggered by pull_request events, use version tag otherwise Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release-sglang-docker.yml:
- Line 7: The run-name's smg variable currently defaults to a hard-coded
'v1.3.0' (smg=${{ inputs.smg_commit || 'v1.3.0' }}) which can mismatch the
expression used elsewhere for PR runs; update the smg assignment to mirror the
same expression used for pull_request runs (the same conditional used later in
the file) so that smg and run-name consistently reflect the effective commit/ref
(use the existing conditional logic instead of the hard-coded 'v1.3.0',
referencing smg and inputs.smg_commit).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 685a4433-81f0-471a-b2cf-5f6409d7cbdb
📒 Files selected for processing (4)
.github/workflows/_build-engine-image.yml.github/workflows/release-sglang-docker.yml.github/workflows/release-trtllm-docker.yml.github/workflows/release-vllm-docker.yml
Signed-off-by: Simo Lin <linsimo.mark@gmail.com>
Summary
Bump all crate and artifact versions for the v1.3.0 release.
What changed
Why
New features merged since v1.2.0 (Messages API gRPC support, mesh HA sync, WebRTC plumbing, MCP extraction) require a minor version bump.
Test plan
make check-versionspasses with no issues after applying fixesSummary by CodeRabbit