Repository navigation
ci(release): build the TokenSpeed image against SMG v1.11.0 - #2676
Conversation
release-tokenspeed-docker.yml defaulted smg_commit to v1.7.0, and its automatic trigger (a push to main touching bindings/python/pyproject.toml, i.e. the release bump) carries no inputs, so every automatically built smg-tokenspeed release image since 1.7.0 shipped SMG v1.7.0. The other engine workflows are rewritten by scripts/check_release_versions.sh at release time; this one was missing from its SMG_VERSION_SYNC list. Point the three references at v1.11.0 and register the workflow with the release script so future bumps carry it along. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 SummarySummary by CodeRabbit
WalkthroughThe TokenSpeed Docker release workflow changes its default SMG version from v1.7.0 to v1.11.0. The version-sync script adds the workflow to its registry. ChangesTokenSpeed Docker release
Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to Automatic TokenSpeed Docker builds without an SMG commit will use v1.11.0 instead of v1.7.0, and future version checks will include this workflow. No actionable merge-blocking risk remains; proceed with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Reviewed the workflow version bump and release-script registration — no issues found.
Verified:
- All three
v1.7.0references inrelease-tokenspeed-docker.yml(run-name,smg_commitinput default, build-job input) are nowv1.11.0, and thetagdescription example was updated too; no stalev1.7.0remains in the file. model_gateway/Cargo.tomlis at1.11.0, so the newtokenspeed-dockerentry inSMG_VERSION_SYNCpasses the Phase 1c check on current HEAD.get_workflow_smg_versionextracts the right value: the firstdefault: 'vX.Y.Z'match in this workflow is thesmg_commitinput (the earlier defaults — base image ref,latest, repo URL — don't match the pattern).- Future releases stay in sync:
set_workflow_smg_versionrewrites allvOLDoccurrences globally, so the run-name and build-input fallbacks won't drift again. - Matches the sibling engine workflows (sglang/vllm/trtllm), all at
v1.11.0.
🤖 Generated with Claude Code
Description
Problem
release-tokenspeed-docker.ymldefaultssmg_committov1.7.0in three places (therun-name, theworkflow_dispatchinput default, and thesmg_commitpassed to the reusable build). Its automatic trigger is a push tomainthat touchesbindings/python/pyproject.toml, which is exactly the release version bump, and on that eventinputs.smg_commitis empty, so the fallback wins: every automatically builtsmg-tokenspeedrelease image since 1.7.0 has shipped SMG v1.7.0 inside a current TokenSpeed base.The other three engine workflows (
sglang,vllm,trtllm) sayv1.11.0becausescripts/check_release_versions.shrewrites them at release time; the TokenSpeed workflow was never added to itsSMG_VERSION_SYNClist, so the bump PRs (#2670 most recently) skipped it.Solution
v1.7.0references atv1.11.0, the current release.SMG_VERSION_SYNCso the release script checks and rewrites it with the others from now on. The script'sget_workflow_smg_versionreads the firstdefault: 'vX.Y.Z'in the file, which in this workflow is thesmg_commitinput.Changes
.github/workflows/release-tokenspeed-docker.yml:v1.7.0→v1.11.0(run-name, input default, build input).scripts/check_release_versions.sh: addtokenspeed-dockertoSMG_VERSION_SYNC.No crate version bumps.
Test Plan
The next
workflow_dispatchor version-bump push ofrelease-tokenspeed-docker.ymlbuilds againstv1.11.0; the release script now liststokenspeed-dockeralongside the other engine workflows in its sync check.Checklist
cargo +nightly fmtpasses (no Rust changes)cargo clippy --all-targets --all-features -- -D warningspasses (no Rust changes)