Skip to content

ci(release): build the TokenSpeed image against SMG v1.11.0 - #2676

Merged
slin1237 merged 1 commit into
mainfrom
ci/tokenspeed-image-smg-version
Sep 24, 2026
Merged

slin1237 merged 1 commit into
mainfrom
ci/tokenspeed-image-smg-version

Conversation

@slin1237

Copy link
Copy Markdown
Member

Description

Problem

release-tokenspeed-docker.yml defaults smg_commit to v1.7.0 in three places (the run-name, the workflow_dispatch input default, and the smg_commit passed to the reusable build). Its automatic trigger is a push to main that touches bindings/python/pyproject.toml, which is exactly the release version bump, and on that event inputs.smg_commit is empty, so the fallback wins: every automatically built smg-tokenspeed release image since 1.7.0 has shipped SMG v1.7.0 inside a current TokenSpeed base.

The other three engine workflows (sglang, vllm, trtllm) say v1.11.0 because scripts/check_release_versions.sh rewrites them at release time; the TokenSpeed workflow was never added to its SMG_VERSION_SYNC list, so the bump PRs (#2670 most recently) skipped it.

Solution

  • Point the three v1.7.0 references at v1.11.0, the current release.
  • Register the TokenSpeed workflow in SMG_VERSION_SYNC so the release script checks and rewrites it with the others from now on. The script's get_workflow_smg_version reads the first default: 'vX.Y.Z' in the file, which in this workflow is the smg_commit input.

Changes

  • .github/workflows/release-tokenspeed-docker.yml: v1.7.0 → v1.11.0 (run-name, input default, build input).
  • scripts/check_release_versions.sh: add tokenspeed-docker to SMG_VERSION_SYNC.

No crate version bumps.

Test Plan

bash -n scripts/check_release_versions.sh
grep -n "v1\." .github/workflows/release-tokenspeed-docker.yml

The next workflow_dispatch or version-bump push of release-tokenspeed-docker.yml builds against v1.11.0; the release script now lists tokenspeed-docker alongside the other engine workflows in its sync check.

Checklist
  • cargo +nightly fmt passes (no Rust changes)
  • cargo clippy --all-targets --all-features -- -D warnings passes (no Rust changes)
  • (Optional) Documentation updated
  • (Optional) Please join us on Slack #sig-smg to discuss, review, and merge PRs

release-tokenspeed-docker.yml defaulted smg_commit to v1.7.0, and its
automatic trigger (a push to main touching bindings/python/pyproject.toml,
i.e. the release bump) carries no inputs, so every automatically built
smg-tokenspeed release image since 1.7.0 shipped SMG v1.7.0. The other
engine workflows are rewritten by scripts/check_release_versions.sh at
release time; this one was missing from its SMG_VERSION_SYNC list.

Point the three references at v1.11.0 and register the workflow with the
release script so future bumps carry it along.

Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: ec2fba8c-5fce-4782-b156-dcfc79cb88b3

📥 Commits

Reviewing files that changed from the base of the PR and between 3be823a and 809c447.

📒 Files selected for processing (2)
  • .github/workflows/release-tokenspeed-docker.yml
  • scripts/check_release_versions.sh

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Chores
    • TokenSpeed Docker releases now default to SMG v1.11.0; pull requests continue to use the main branch.
    • Release version checks now include the TokenSpeed Docker workflow, helping keep its SMG version aligned with other registered release files.

Walkthrough

The TokenSpeed Docker release workflow changes its default SMG version from v1.7.0 to v1.11.0. The version-sync script adds the workflow to its registry.

Changes

TokenSpeed Docker release

Layer / File(s) Summary
SMG version default and sync registration
.github/workflows/release-tokenspeed-docker.yml, scripts/check_release_versions.sh
The workflow uses v1.11.0 for its run name, manual-dispatch default, and build fallback. Pull requests continue to use main. The version-sync registry includes the workflow.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 809c4

Automatic TokenSpeed Docker builds without an SMG commit will use v1.11.0 instead of v1.7.0, and future version checks will include this workflow. No actionable merge-blocking risk remains; proceed with normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI release workflow change and the target SMG version, which matches the main changeset.
Description check ✅ Passed The description accurately explains the outdated SMG fallback, the version updates, the registry change, and the test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the ci CI/CD configuration changes label Sep 24, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the workflow version bump and release-script registration — no issues found.

Verified:

  • All three v1.7.0 references in release-tokenspeed-docker.yml (run-name, smg_commit input default, build-job input) are now v1.11.0, and the tag description example was updated too; no stale v1.7.0 remains in the file.
  • model_gateway/Cargo.toml is at 1.11.0, so the new tokenspeed-docker entry in SMG_VERSION_SYNC passes the Phase 1c check on current HEAD.
  • get_workflow_smg_version extracts the right value: the first default: 'vX.Y.Z' match in this workflow is the smg_commit input (the earlier defaults — base image ref, latest, repo URL — don't match the pattern).
  • Future releases stay in sync: set_workflow_smg_version rewrites all vOLD occurrences globally, so the run-name and build-input fallbacks won't drift again.
  • Matches the sibling engine workflows (sglang/vllm/trtllm), all at v1.11.0.

🤖 Generated with Claude Code

@slin1237
slin1237 merged commit 3c58eab into main Sep 24, 2026
37 of 38 checks passed
@slin1237
slin1237 deleted the ci/tokenspeed-image-smg-version branch September 24, 2026 18:43
@slin1237 slin1237 mentioned this pull request Oct 8, 2026
1 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant