Repository navigation
Conversation
|
/tag-and-rerun-ci |
|
Native AMD results for The full AMD unit step is not green: it hits its 30-minute step timeout at CUDA unit, 5090, B200, component-accuracy and XPU checks pass. The remaining CUDA 2-GPU partition 1 failure reports Wan load times 106.03 s / 91.77 s versus limits 79.92 s / 58.00 s, and LTX-2.5 E2E 15.57 s versus 12.68 s. Those timings need same-runner base comparison; thresholds remain unchanged. NPU still fails at the wheel download (403), before model tests. The separate FP8 fix #42255 has now passed its targeted tests on real MI300 hardware. The other platform-policy/fallback fixes #42250/#42256/#42257 still await CI authorization. |
|
Synced with upstream Further inspection of the previous AMD timeout found that the existing nine performance-failure runner tests occupied about 1,366.5 s of the 1,800 s step budget, from adjacent log timestamps. Each scenario restarts pytest for an initial attempt plus six retries: 63 pytest startups. The four new cold imports separately took 47.5 s, so I am not claiming zero contribution from this PR's test cost. The separate test-only fix #42359 batches the nine independently parametrized scenarios into the same seven real attempts, preserving per-case failure/metric/JUnit checks. On the updated head #42359's complete file was separately measured on the same host: upstream 888.28 s -> candidate 117.36 s (86.8% less time). All nine child scenarios still run seven times; the complete file also passes with an already-expired outer retry budget. These are local test-runtime results, not a claim that the full AMD suite now passes. No timeout/threshold/retry-limit changes. Please authorize CI for #42359 and evaluate this updated head. Remaining platform-policy/PTX/LoRA fixes are still separate in #42250/#42256/#42257. |
|
Synced with upstream #42494 at Source hashes, diffs, and logs for that validation: https://github.com/Tokha233/ComfyUI-H3-SpeedKit/tree/8791760/evidence/pr-maintenance-1005 . CI update, 2026-10-05 07:22 UTC, current head Current-head CUDA failure breakdown:
Current-head AMD has now finished failed, with 5/6 diffusion partitions passed. 2-GPU partition 1 again hit the 180-minute step timeout at 06:45 UTC. Its first pass reported 13 passed, 1 skipped, 1 error; H3 T2VA and Ref2VA both passed. The only reported case error was Previous-head results (`b62a8588`; retained for history, not current-head validation)
No tolerance, startup timeout, or retry policy has been changed by this PR. |
Motivation
Upstream #42494 now defers diffusion quantization imports until registry lookup, fixing the cold
LinearBaseimport cycle originally reported here. Its lookup still imports every backend and no longer exposes the configuration classes directly from the package. This PR resolves only the requested backend while retaining the previous package-level class exports, registry aliases, and custom registration behavior.Changes
Keep
QuantizationConfigavailable during package initialization. Resolve and cache implementation classes through module__getattr__, and look up built-in configurations by their export name. Preservekitchen_int8→convrot_int8, distinct ModelOpt configuration classes, and user-defined configurations.Fresh-process regression tests cover
linear,hf_diffusers_utils, the standalone AR module, and ConvRot config imports. Registry tests cover all built-ins, package exports, repeated lookups, the deprecated alias, and custom registration failures.Validation
Synced with upstream
bab04cd7913ff50d1bf1a677a2d10e5015dc4c3b, including #42494. This preserves the upstream HIP H3 and CI changes.RTX 5090 D v2, Python 3.12, PyTorch 2.13.0+cu130:
git diff --checkpassed.Earlier native AMD CI passed the four cold-import checks on a previous head; the synchronized head still needs hosted AMD validation. No model-forward math, precision, thresholds, or inference speedup claim. Codex assisted with implementation and testing.
CI States
Latest PR Test (Base): ❌ Run #37256707983
Latest PR Test (Extra): ❌ Run #37256707704
Latest PR Test (AMD ROCm 10): ❌ Run #37256707869