Repository navigation
Conversation
Tokha233
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
kevin-mii,
mickqian,
niehen6174,
ping1jing2 and
yichiche
as code owners
October 2, 2026 18:38
4 tasks done
This was referenced Oct 3, 2026
Contributor
Author
|
Resolved the upstream conflict in Logs and exact diff: https://github.com/Tokha233/ComfyUI-H3-SpeedKit/tree/8791760/evidence/pr-maintenance-1005 . The new GPU workflows stop at the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Diffusion latency guards deliberately reject over-budget CUDA runs but only warn on HIP. Tests must cover both policies without depending on the host GPU.
Upstream #42391 already merged the fixture platform isolation originally proposed here. This PR is now limited to four additional regression cases: E2E/load latency crossed with CUDA/HIP policy. It checks that an in-budget request emits no warning, an over-budget CUDA request raises, and an over-budget HIP request emits exactly one AMD performance warning. Production validators and thresholds are unchanged.
Validation
Synced with upstream
bab04cd7913ff50d1bf1a677a2d10e5015dc4c3b. The remaining diff is 21 lines intest_load_inclusive_e2e.py.RTX 5090 D v2, Python 3.12, PyTorch 2.13.0+cu130:
git diff --checkpassed.No inference speedup or native AMD execution is claimed. Codex assisted with implementation and testing.
CI States
Latest PR Test (Base): ❌ Run #37233246273
Latest PR Test (Extra): ❌ Run #37233246161
Latest PR Test (AMD ROCm 10): ❌ Run #37233246322