Repository navigation
[AMD] Fix RoPE cache dtype and diffusion CI failures - #42494
Merged
BBuf merged 4 commits intoOct 4, 2026
Merged
Conversation
4 tasks done
BBuf
marked this pull request as ready for review
October 4, 2026 12:10
BBuf
requested review from
AgainstEntropy,
BowenBao,
Fridge003,
HaiShaw,
Kangyan-Zhou,
OrangeRedeng,
bingxche,
ispobock,
kevin-mii,
merrymercy,
mickqian,
niehen6174,
ping1jing2 and
yichiche
as code owners
October 4, 2026 12:10
This was referenced Oct 5, 2026
This was referenced Oct 6, 2026
4 tasks done
This was referenced Oct 8, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCm Llama startup fails during graph capture because #41282 keeps the RoPE cache in FP32 while the fallback kernel assumes the query dtype. Let the kernel read FP32 caches and round cos/sin to the query dtype before the existing arithmetic. This preserves the FP32 cache used by QSA without converting the whole cache on every forward.
The diffusion fixes defer quantization imports to break the linear-layer import cycle, enable the existing MiniMax H3 denoising path on HIP, pass the existing HF credential to dual-GPU tests, and install ffmpeg/ffprobe for H3 media validation.
The existing ROCm RoPE test now runs even with AITER enabled, checks FP32-cache outputs against the same-dtype kernel bit for bit, and runs in Stage A so it catches this failure before the longer suites. Correctness, performance and startup thresholds are unchanged.
Validation:
Follow-up to #42391. The RoPE failure was already present in the base code and is fixed here as part of the ROCm CI follow-up.
CI States
Latest PR Test (Base): ⏳ Run #37210510580
Latest PR Test (Extra): ❌ Run #37210510389
Latest PR Test (AMD ROCm 10): ⏳ Run #37210510566