Repository navigation
Conversation
Tokha233
requested review from
AgainstEntropy,
BBuf,
DarkSharpness,
HaiShaw,
HydraQYH,
celve,
kevin-mii,
mickqian,
niehen6174,
ping1jing2,
yichiche and
yuan-luo
as code owners
October 2, 2026 19:15
4 tasks done
This was referenced Oct 2, 2026
This was referenced Oct 3, 2026
Contributor
Author
|
Resolved the conflict in Local pre-commit and GitHub lint passed. Logs/diffs: https://github.com/Tokha233/ComfyUI-H3-SpeedKit/tree/8791760/evidence/pr-maintenance-1005 . Hosted GPU tests currently stop at the |
This was referenced Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ROCm tensors also report
is_cuda, but the diffusion residual fast path contains NVIDIA PTX. Upstream #42391 already merged the HIP eligibility guard and simplified the native dispatch. This PR now adds regression coverage on top of that implementation; it changes no production kernel.Changes
atol=0, rtol=0.Validation
Synced with upstream
bab04cd7913ff50d1bf1a677a2d10e5015dc4c3b.RTX 5090 D v2, Python 3.12, PyTorch 2.13.0+cu130: 44 passed across the full residual-dispatch and Qwen CUDA test files. CUDA kernels, small-model forwards, prefix caches, and graph replay ran on the real GPU. HIP eligibility was simulated on that host; native AMD execution is still required from CI.
Changed-file pre-commit and
git diff --checkpassed. Complete source content was verified against the local Git index and working-tree changes before the remote run. Existing tolerances were not relaxed. No new inference performance claim. Codex assisted with implementation and testing.CI States
Latest PR Test (Base): ❌ Run #37233260867
Latest PR Test (Extra): ❌ Run #37233260677
Latest PR Test (AMD ROCm 10): ❌ Run #37233260792