Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Env Documentation #668

Merged
merged 78 commits into from
Oct 25, 2018
Merged

Clean Up Env Documentation #668

merged 78 commits into from
Oct 25, 2018

Conversation

rawkode
Copy link
Contributor

@rawkode rawkode commented Oct 10, 2018

There were some conflicting configuration details, namely .env_sample,
and sendgrid.env. I've opted for .env_sample, as sendgrid.env
actually seemed to be incorrect.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 10, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #668 into v4 will increase coverage by 0.42%.
The diff coverage is 74.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4     #668      +/-   ##
==========================================
+ Coverage   84.35%   84.77%   +0.42%     
==========================================
  Files          36       35       -1     
  Lines         965     1156     +191     
  Branches      107      172      +65     
==========================================
+ Hits          814      980     +166     
+ Misses         93       90       -3     
- Partials       58       86      +28
Impacted Files Coverage Δ
sendgrid/sendgrid.py 92% <ø> (+6.28%) ⬆️
sendgrid/helpers/mail/personalization.py 93.25% <100%> (+0.2%) ⬆️
sendgrid/helpers/stats/__init__.py 100% <100%> (ø)
sendgrid/version.py 100% <100%> (ø)
sendgrid/helpers/endpoints/ip/unassigned.py 15% <15%> (ø)
sendgrid/helpers/mail/mail.py 93.71% <50%> (-6.29%) ⬇️
sendgrid/helpers/stats/stats.py 82.19% <82.19%> (ø)
sendgrid/helpers/mail/__init__.py 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd02e4...1627df7. Read the comment docs.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: medium fix is medium in difficulty type: docs update documentation change not affecting the code labels Oct 11, 2018
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @rawkode,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @rawkode,

Could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@rawkode rawkode changed the base branch from master to v4 October 25, 2018 12:53
@rawkode rawkode closed this Oct 25, 2018
@rawkode rawkode merged commit 1627df7 into sendgrid:master Oct 25, 2018
@rawkode rawkode changed the base branch from v4 to master October 25, 2018 14:57
@thinkingserious
Copy link
Contributor

Hello @rawkode,

Thanks again for the PR!

We noticed that you have earned 4 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@rawkode rawkode deleted the bugfix/remove-duplicate-sample-env branch October 26, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.