Cleanup Env Documentation #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
rawkode
force-pushed
the
bugfix/clean-up-docker-env
branch
from
a1a29b6
to
e1f043c
Compare
There were some conflicting configuration details, namely .env_sample, and sendgrid.env. I've opted for .env_sample, as sendgrid.env actually seemed to be incorrect.
rawkode
force-pushed
the
bugfix/clean-up-docker-env
branch
from
e1f043c
to
a83c82a
Compare
Codecov Report
@@ Coverage Diff @@
## v4 #709 +/- ##
=======================================
Coverage 84.35% 84.35%
=======================================
Files 36 36
Lines 965 965
Branches 107 107
=======================================
Hits 814 814
Misses 93 93
Partials 58 58Continue to review full report at Codecov.
|
misterdorm
added
hacktoberfest
difficulty: medium
misterdorm
approved these changes
Oct 30, 2018
|
Hello @rawkode, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #668 against v4
There were some conflicting configuration details, namely .env_sample,
and sendgrid.env. I've opted for .env_sample, as sendgrid.env
actually seemed to be incorrect.