Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #610 #611

Merged
merged 1 commit into from
Oct 1, 2018
Merged

fixes #610 #611

merged 1 commit into from
Oct 1, 2018

Conversation

themousepotato
Copy link
Contributor

@themousepotato themousepotato commented Sep 28, 2018

Fixes # 610

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fix broken link in the README

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 28, 2018
@SendGridDX
Copy link

SendGridDX commented Sep 28, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #611 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f7cf2...aba7f04. Read the comment docs.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: cla not signed and removed status: code review request requesting a community code review or review from Twilio labels Sep 28, 2018
@thinkingserious thinkingserious merged commit 308c19e into sendgrid:master Oct 1, 2018
@thinkingserious
Copy link
Contributor

Hello @themousepotato,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@themousepotato
Copy link
Contributor Author

themousepotato commented Oct 2, 2018

For sure. Done @thinkingserious :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants