Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md by including email #613

Merged
merged 7 commits into from
Oct 4, 2018
Merged

Update README.md by including email #613

merged 7 commits into from
Oct 4, 2018

Conversation

bharatr21
Copy link
Contributor

Make it clear that the link is a redirect to an email and not to any members page or developer team page

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

themousepotato and others added 2 commits September 28, 2018 09:41
@themousepotato
fixes sendgrid#610
aba7f04
@bharatr21
Update README.md by including email
29fa10d 
Make it clear that the link is a redirect to an email and not to any members page or developer team page
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 1, 2018 •
edited
Loading

Codecov Report

Merging #613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86
Impacted Files Coverage Δ
sendgrid/helpers/endpoints/ip/unassigned.py 15% <ø> (ø) ⬆️
sendgrid/sendgrid.py 92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f7cf2...3e09b20. Read the comment docs.

@bharatr21 bharatr21 mentioned this pull request Oct 1, 2018
Closed
@thinkingserious
Copy link
Contributor

This content is redundant, but I encourage you to participate in our Hacktoberfest celebration!

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: invalid issues not related to the library difficulty: unknown or n/a fix is unknown in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 2, 2018
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy and removed difficulty: unknown or n/a fix is unknown in difficulty status: invalid issues not related to the library labels Oct 2, 2018
thinkingserious
thinkingserious reviewed Oct 2, 2018
View reviewed changes
README.md
@@ -224,7 +224,8 @@ Please see our [troubleshooting guide](https://github.com/sendgrid/sendgrid-pyth
<a name="about"></a>
# About

sendgrid-python is guided and supported by the SendGrid [Developer Experience Team](mailto:[email protected]).
sendgrid-python is guided and supported by the SendGrid Developer Experience Team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space between these two lines. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed spacing and alphabetical order

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code and removed status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap labels Oct 2, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy labels Oct 4, 2018
@thinkingserious thinkingserious added status: hacktoberfest approved and removed difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter labels Oct 4, 2018
@thinkingserious
Copy link
Contributor

Hello @Bharat123rox,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious removed the type: docs update documentation change not affecting the code label Oct 4, 2018
@thinkingserious thinkingserious merged commit 3692e71 into sendgrid:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bharatr21 @thinkingserious @themousepotato @hugovk